[illumos-Advocates] [RTI] 847 856 853 854 858 808 860

Albert Lee trisk at opensolaris.org
Fri Apr 1 10:57:32 PDT 2011


On Fri, Apr 1, 2011 at 12:10 PM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> I suggest Trisk for 808.
>

Already reviewed on the original webrev thread.

Thanks,
-Albert

> On Fri, Apr 1, 2011 at 1:15 AM, Richard Lowe <richlowe at richlowe.net> wrote:
>> I'd ideally like reviewers and advocates to differ, so if someone not
>> Garrett could do #808 and someone not Gordon do the rest, that'd be
>> swell.
>> I plan to be largely offline on the 1st, because I have a remarkably
>> short temper.
>>
>> outgoing:
>>
>> comparing with /builds/illumos-clone
>> searching for changes
>>
>> changeset:   13313:52c14122bc72
>> tag:         qbase
>> tag:         sys-lib.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:04 2011 -0400
>>
>> description:
>>        853 system/library is missing references to some license files
>>        Reviewed by: gwr at nexenta.com
>>
>> removed:
>>   usr/src/lib/libc/amd64/gen/THIRDPARTYLICENSE
>>   usr/src/lib/libc/port/fp/THIRDPARTYLICENSE
>>
>>
>> changeset:   13314:5afafa16a4c1
>> tag:         post-man.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:04 2011 -0400
>>
>> description:
>>        847 post* manual pages made obsolete by #111 should be removed
>>        Reviewed by: gwr at nexenta.com
>>
>> modified:
>>   usr/src/man/man1/Makefile
>>   usr/src/pkg/manifests/print-lp-filter-postscript-lp-filter.mf
>> removed:
>>   usr/src/man/man1/postdaisy.1
>>   usr/src/man/man1/postdmd.1
>>   usr/src/man/man1/postmd.1
>>   usr/src/man/man1/postplot.1
>>   usr/src/man/man1/posttek.1
>>
>>
>> changeset:   13315:c155da86762b
>> tag:         post-eof.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:05 2011 -0400
>>
>> description:
>>        854 postscript filter EOF missed some bits
>>        Reviewed by: gwr at nexenta.com
>>
>> modified:
>>   usr/src/cmd/lp/filter/postscript/README
>>   usr/src/cmd/lp/filter/postscript/common/path.h
>>   usr/src/cmd/lp/filter/postscript/postscript/README
>> removed:
>>   usr/src/cmd/lp/filter/postscript/postscript/postdaisy.ps
>>   usr/src/cmd/lp/filter/postscript/postscript/postdmd.ps
>>   usr/src/cmd/lp/filter/postscript/postscript/postmd.ps
>>   usr/src/cmd/lp/filter/postscript/postscript/postplot.ps
>>   usr/src/cmd/lp/filter/postscript/postscript/posttek.ps
>>
>>
>> changeset:   13316:6dca633dfd43
>> tag:         cs-exp-home.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:05 2011 -0400
>>
>> description:
>>        856 SUNWcs should deliver /export and /home
>>        Reviewed by: gwr at nexenta.com
>>
>> modified:
>>   usr/src/pkg/manifests/SUNWcs.mf
>>   usr/src/pkg/manifests/compatibility-ucb.mf
>>
>>
>> changeset:   13317:90b8c144df05
>> tag:         doc-dep.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:05 2011 -0400
>>
>> description:
>>        858 text/doctools should have dependencies on things man(1) needs
>>        Reviewed by: gwr at nexenta.com
>>
>> modified:
>>   usr/src/pkg/manifests/text-doctools.mf
>>
>>
>> changeset:   13318:8ad2a0ce10d6
>> tag:         860.diff
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Thu Mar 31 15:21:05 2011 -0400
>>
>> description:
>>        860 storage/storage-server shouldn't depend on zfs-auto-snapshot
>>        Reviewed by: gwr at nexenta.com
>>
>> modified:
>>   usr/src/pkg/manifests/storage-storage-server.mf
>>
>>
>> changeset:   13319:c28d7850752f
>> tag:         hg-18.diff
>> tag:         qtip
>> tag:         tip
>> user:        Richard Lowe <richlowe at richlowe.net>
>> date:        Fri Mar 25 18:38:13 2011 -0400
>>
>> description:
>>        808 developer tools should support mercurial 1.8
>>        Reviewed by: garrett at nexenta.com
>>
>> modified:
>>   usr/src/tools/onbld/Scm/Backup.py
>>   usr/src/tools/onbld/Scm/Version.py
>>   usr/src/tools/onbld/Scm/WorkSpace.py
>>
>>
>> pbchk:
>> Copyright check:
>> usr/src/cmd/lp/filter/postscript/README: no copyright message found
>> usr/src/cmd/lp/filter/postscript/common/path.h: no copyright claim for
>> current year found
>> usr/src/cmd/lp/filter/postscript/postscript/README: no copyright message found
>> usr/src/pkg/manifests/SUNWcs.mf: no copyright claim for current year found
>> usr/src/pkg/manifests/compatibility-ucb.mf: no copyright claim for
>> current year found
>> usr/src/pkg/manifests/print-lp-filter-postscript-lp-filter.mf: no
>> copyright claim for current year found
>> usr/src/pkg/manifests/storage-storage-server.mf: no copyright claim
>> for current year found
>> usr/src/pkg/manifests/text-doctools.mf: no copyright claim for current
>> year found
>>
>> Header format check:
>> usr/src/cmd/lp/filter/postscript/common/path.h: line 30: Invalid or
>> missing header guard
>> usr/src/cmd/lp/filter/postscript/common/path.h: Missing or invalid
>> ending header guard
>>
>> copyright warnings are intentional on my part.  The specific checks of
>> path.h only apply to delivered headers, of which this is not one.
>>
>> testing:
>>
>>  808: Passed test suites, used by me somewhat
>>  853: Installed system/library, used 'pkg info --license
>> system/library' to be sure licenses were really still there
>>  847: made sure they went away
>>  854: Build still works, they vanished from the unref file list
>> (though sadly not in the build my mail_msg is from)
>>  856: Made sure /export and /home were attributed to SUNWcs now
>>  858: Verified dependencies I wanted to be present all were
>>  860: Installed it, made sure dependency on zfs-auto-snapshot wasn't there
>>
>> -- Rich
>>
>> _______________________________________________
>> Advocates mailing list
>> Advocates at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/advocates
>>
>>
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>



More information about the Advocates mailing list