[illumos-Advocates] RTI: 842 remove vestiges of libc_i18n.a

[Gordon Ross]

Looks fine to me.  I gather that you left copyrights alone where the
only changes
were to delete lines.  We need to get after that lint some time...

Approved.

On Tue, Apr 5, 2011 at 10:14 AM, Garrett D'Amore <garrett at nexenta.com> wrote:
>  webrev: http://mexico.purplecow.org/gdamore/webrev/nolibci18n/
>
> garrett at thinkpad{27}> hg outgoing -v
> running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> searching for changes
>
> changeset:   13325:f8ec82fc7d5c
> tag:         tip
> user:        Garrett D'Amore <garrett at nexenta.com>
> date:        Tue Apr 05 07:11:13 2011 -0700
>
> description:
>    842 src/lib/Makefile has libc_i18n vestiges
>    Reviewed by: Rich Lowe <richlowe at richlowe.net>
>    Reviewed by: Albert Lee <trisk at nexenta.com>
>
> modified:
>   usr/src/lib/Makefile
>   usr/src/lib/libc/README
>   usr/src/pkg/manifests/developer-build-onbld.mf
>   usr/src/tools/scripts/Makefile
>   usr/src/tools/scripts/nightly.sh
> removed:
>   usr/src/tools/scripts/mkclosed.sh
>
>
> garrett at thinkpad{28}>  hg pbchk
> Copyright check:
> usr/src/lib/Makefile: no copyright claim for current year found
> usr/src/lib/libc/README: no copyright claim for current year found
> usr/src/pkg/manifests/developer-build-onbld.mf: no copyright claim for
> current year found
> usr/src/tools/scripts/Makefile: no copyright claim for current year found
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
>
> Nightly build mail_msg:
>
> garrett at thinkpad{30}> cat log/log.2011-04-04.02:29/mail_msg
>
> ==== Nightly distributed build started:   Mon Apr  4 00:29:14 PDT 2011 ====
> ==== Nightly distributed build completed: Mon Apr  4 02:29:36 PDT 2011 ====
>
> ==== Total build time ====
>
> real    2:00:22
>
> ==== Build environment ====
>
> /usr/bin/uname
> SunOS thinkpad 5.11 locale2 i86pc i386 i86pc
>
> /opt/SUNWspro/bin/dmake
> dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
> number of concurrent jobs = 10
>
> 32-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> 64-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> /usr/java/bin/javac
> java full version "1.6.0_21-b06"
>
> /usr/ccs/bin/as
> as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
>
> /usr/ccs/bin/ld
> ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726
>
> Build project:  group.staff
> Build taskid:   158
>
> ==== Nightly argument issues ====
>
>
> ==== Build version ====
>
> qlc2322
>
> ==== Make clobber ERRORS ====
>
>
> ==== Make tools clobber ERRORS ====
>
>
> ==== Tools build errors ====
>
>
> ==== Build errors (DEBUG) ====
>
>
> ==== Build warnings (DEBUG) ====
>
>
> ==== Elapsed build time (DEBUG) ====
>
> real  1:15:15.3
> user  6:42:04.6
> sys   1:19:28.0
>
> ==== Build noise differences (DEBUG) ====
>
>
> ==== package build errors (DEBUG) ====
>
>
> ==== Validating manifests against proto area ====
>
>
> ==== Check ELF runtime attributes ====
>
>
> ==== Diff ELF runtime attributes (since last build) ====
>
>
> ==== 'dmake lint' of src ERRORS ====
>
>
> ==== Elapsed time of 'dmake lint' of src ====
>
> real    30:21.3
> user  1:37:13.1
> sys     51:06.7
>
> ==== lint warnings src ====
>
> "../common/be_utils.c", line 3525: warning: argument unused in function:
> pool_mntpt in be_create_menu (E_FUNC_ARG_UNUSED)
>
> ==== lint noise differences src ====
>
>
> ==== cstyle/hdrchk errors ====
>
>
> ==== Find core files ====
>
>
> ==== Check lists of files ====
>
>
> ==== Impact on file permissions ====
>
>
>
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>