[illumos-Advocates] RTI 878 regerror() error messages not i18n compliant

[Gordon Ross]

Looks OK to me, though it would be easier to see that if you would
run another build.  The diffs from previous make that hard to see.
Also, the smbrdr lint is fixed,  if you pull and reci before rebuild.


On Sun, Apr 10, 2011 at 1:29 AM, Garrett D'Amore <garrett at nexenta.com> wrote:
>  webrev: http://mexico.purplecow.org/gdamore/webrev/regerror
>
>
> garrett at thinkpad{16}> hg outgoing -v
> running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> searching for changes
>
> changeset:   13330:a92ab1dd66a1
> tag:         tip
> user:        Garrett D'Amore <garrett at nexenta.com>
> date:        Sat Apr 09 22:27:59 2011 -0700
>
> description:
>    878 regerror() error messages not i18n compliant
>    Reviewed by: Adam Leventhal <ahl at delphix.com>
>
> modified:
>   usr/src/lib/libc/makelibccatalog.sh
>   usr/src/lib/libc/port/locale/regerror.c
> removed:
>   usr/src/lib/libc/port/i18n/regerror_msg.h
>
>
> garrett at thinkpad{17}> hg pbchk
> Copyright check:
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
>
> Testing:
>
> I tested using vi and egrep to try plugging in various invalid regular
> expressions and checking the response codes, on a system that had these
> changes onu'd.
>
> The attached nightly build log shows lots of warning "diffs" from a previous
> broken build, and a new lint error that was introduced in a prior
> integration (smbdr) by Gordon Ross (so not my problem).
>
>
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>
>