[illumos-Advocates] RTI: 707 sata framework is unsure of bitwise ops

[Albert Lee]

Approved, and you also have relling's review now.

-Albert

On Mon, Apr 11, 2011 at 2:38 PM, Garrett D'Amore <garrett at nexenta.com> wrote:
>  running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> searching for changes
>
> changeset:   13336:72b1a7c35e05
> tag:         tip
> user:        Garrett D'Amore <garrett at nexenta.com>
> date:        Mon Apr 11 11:32:10 2011 -0700
>
> description:
>    707 sata framework is unsure of bitwise ops
>    Reviewed by: Dan McDonald <danmcd at nexenta.com>
>    Reviewed by: Albert Lee <trisk at nexenta.com>
>    Reviewed by: Roland Mainz <roland.mainz at nexenta.com>
>
> modified:
>   usr/src/uts/common/io/sata/impl/sata.c
>
> garrett at thinkpad{42}> hg pbchk
> Copyright check:
> usr/src/uts/common/io/sata/impl/sata.c: no copyright claim for current year
> found
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
>
> nightly build:
>
>
>
> ==== Nightly distributed build started:   Sun Apr 10 22:53:28 PDT 2011 ====
> ==== Nightly distributed build completed: Mon Apr 11 00:58:46 PDT 2011 ====
>
> ==== Total build time ====
>
> real    2:05:17
>
> ==== Build environment ====
>
> /usr/bin/uname
> SunOS thinkpad 5.11 qlc2322 i86pc i386 i86pc
>
> /opt/SUNWspro/bin/dmake
> dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
> number of concurrent jobs = 10
>
> 32-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> 64-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> /usr/java/bin/javac
> java full version "1.6.0_21-b06"
>
> /usr/ccs/bin/as
> as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
>
> /usr/ccs/bin/ld
> ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726
>
> Build project:  group.staff
> Build taskid:   142
>
> ==== Nightly argument issues ====
>
>
> ==== Build version ====
>
> qlc2322
>
> ==== Make clobber ERRORS ====
>
>
> ==== Make tools clobber ERRORS ====
>
>
> ==== Tools build errors ====
>
>
> ==== Build errors (DEBUG) ====
>
>
> ==== Build warnings (DEBUG) ====
>
>
> ==== Elapsed build time (DEBUG) ====
>
> real  1:17:11.1
> user  6:42:11.7
> sys   1:21:40.0
>
> ==== Build noise differences (DEBUG) ====
>
> 161d160
> < ln: /data/work/qlc2322/proto/root_i386/usr/bin/pmap: File exists
>
> ==== package build errors (DEBUG) ====
>
>
> ==== Validating manifests against proto area ====
>
>
> ==== Check ELF runtime attributes ====
>
>
> ==== Diff ELF runtime attributes (since last build) ====
>
>
> ==== 'dmake lint' of src ERRORS ====
>
>
> ==== Elapsed time of 'dmake lint' of src ====
>
> real    31:43.0
> user  1:40:03.7
> sys     37:54.1
>
> ==== lint warnings src ====
>
>
> ==== lint noise differences src ====
>
> 1d0
> < "/data/work/qlc2322/usr/src/lib/smbsrv/libsmbrdr/common/smbrdr_session.c",
> line 232: warning: function returns value which is always ignored:
> setsockopt (E_FUNC_RET_ALWAYS_IGNOR2)
>
> ==== cstyle/hdrchk errors ====
>
>
> ==== Find core files ====
>
>
> ==== Check lists of files ====
>
>
> ==== Impact on file permissions ====
>
>
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>