[illumos-Advocates] RTI 896 sata module can panic on smartctl issued in vbox

[Gordon Ross]

LGTM.


>   Can I please get an advocate to review this?
> 
>      - Garrett
> 
> On 04/11/11 08:45 PM, Garrett D'Amore wrote:
> >
> >
> > http://mexico.purplecow.org/gdamore/webrev/satapanic/
> >
> > (There is one trivial lint fix, and a couple of whitespace fixes
> for 
> > cstyle, that I've made since the above webrev, but I have not 
> > regenerated the webrev.  I don't think this was significant enough
> to 
> > warrant a new review.)
> >
> > I've tested this code on virtual box, where the panic is readily 
> > reproducible using smartctl.  The command that smartctl uses causes
> a 
> > SATA reset to be issued.  After this code, the panic is no longer 
> > reproducible.  I have used this code (and am using it) on m primary 
> > workstation for a number of hours now.
> >
> > hg outgoing -v:
> >
> > running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> > comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> > searching for changes
> >
> > changeset:   13337:ebf76b61349f
> > tag:         tip
> > user:        Garrett D'Amore <garrett at nexenta.com>
> > date:        Mon Apr 11 20:37:33 2011 -0700
> >
> > description:
> >     896 sata module can panic on smartctl issued in vbox
> >     Reviewed by: Albert Lee <trisk at nexenta.com>
> >     Reviewed by: Gordon Ross <gwr at nexenta.com>
> >
> > modified:
> >    usr/src/uts/common/io/sata/impl/sata.c
> >
> > hg pbchk:
[...]