[illumos-Advocates] [RTI] 789, 905, 906, 908, 922, 939, 940, 949
Garrett D'Amore
garrett at damore.org
Tue Apr 26 16:23:25 PDT 2011
Rti approved.
Richard Lowe <richlowe at richlowe.net> wrote:
>I'd like approval to integrate:
>
> 789 dtrace may drop instructions when rapidly signalled
> 905 want llquantize() support in DTrace
> 906 dtrace depends_on pragma should search all library paths, not
>just the current one
> 908 dtrace in the global zone may miss USDT probes in local zones
> 922 SUNWdtrt needs some love
> 939 SUNWdtrt needs to be willing to use 64bit java
> 940 llquantize() dreams of JNI
> 949 dtrace should only include the first instance of a library found
>on its library path
>
>outgoing:
>
> comparing with /builds/illumos-clone
> searching for changes
>
> changeset: 13350:7398553e3d46
> tag: 13350.diff
> tag: qbase
> user: Richard Lowe <richlowe at richlowe.net>
> date: Tue Apr 19 13:31:18 2011 -0400
>
> description:
> 922 SUNWdtrt needs some love
> Reviewed by: Eric Schrock <eric.schrock at delphix.com>
> Reviewed by: Dan McDonald <danmcd at nexenta.com>
> Reviewed by: Garrett D'Amore <garrett at nexenta.com>
>
> modified:
> usr/src/cmd/dtrace/test/tst/common/mdb/tst.dtracedcmd.ksh
> usr/src/cmd/dtrace/test/tst/common/misc/tst.include.ksh
> usr/src/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh.out
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.ufunc.ksh
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.umod.ksh
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.usym.ksh
> usr/src/cmd/dtrace/test/tst/common/safety/tst.violentdeath.ksh
> usr/src/cmd/dtrace/test/tst/common/ustack/tst.spin.ksh
> usr/src/lib/libreparse/common/fs_reparse_lib.c
> usr/src/uts/common/fs/fs_reparse.h
>
>
> changeset: 13351:42c1736826f8
> tag: 13351.diff
> user: Richard Lowe <richlowe at richlowe.net>
> date: Thu Apr 21 21:15:38 2011 +0100
>
> description:
> 939 SUNWdtrt needs to be willing to use 64bit java
> Reviewed by: Albert Lee <trisk at opensolaris.org>
> Reviewed by: Garrett D'Amore <garrett at nexenta.com>
>
> modified:
> usr/src/cmd/dtrace/test/cmd/jdtrace/jdtrace.c
> usr/src/pkg/manifests/system-dtrace-tests.mf
>
>
> changeset: 13352:af935ca1df8c
> tag: 13352.diff
> user: Bryan Cantrill <bryan at joyent.com>
> date: Thu Jan 20 15:03:16 2011 -0800
>
> description:
> 908 dtrace in the global zone may miss USDT probes in local zones
> Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
> Reviewed by: David Pacheco <dap at joyent.com>
>
> modified:
> usr/src/uts/common/dtrace/dtrace.c
>
>
> changeset: 13353:96fee064a552
> tag: 13353.diff
> user: Robert Mustacchi <robert.mustacchi at joyent.com>
> date: Sun Feb 06 17:02:17 2011 -0800
>
> description:
> 906 dtrace depends_on pragma should search all library
>paths, not just the current one
> Reviewed by: Bryan Cantrill <bryan at joyent.com>
>
> modified:
> usr/src/lib/libdtrace/common/dt_cc.c
> usr/src/lib/libdtrace/common/dt_pragma.c
> usr/src/pkg/manifests/system-dtrace-tests.mf
> added:
> usr/src/cmd/dtrace/test/tst/common/pragma/tst.libdepsepdir.ksh
>
>
> changeset: 13354:7f85861a437f
> tag: 13354.diff
> user: Robert Mustacchi <robert.mustacchi at joyent.com>
> date: Sun Mar 13 18:28:09 2011 -0700
>
> description:
> 949 dtrace should only include the first instance of a
>library found on its library path
> Reviewed by: Bryan Cantrill <bryan at joyent.com>
>
> modified:
> usr/src/lib/libdtrace/common/dt_cc.c
> usr/src/pkg/manifests/system-dtrace-tests.mf
> added:
> usr/src/cmd/dtrace/test/tst/common/include/tst.includefirst.ksh
>
>
> changeset: 13355:a48acba9c1b5
> tag: 13355.diff
> user: Bryan Cantrill <bryan at joyent.com>
> date: Tue Feb 08 01:46:16 2011 -0800
>
> description:
> 905 want llquantize() support in DTrace
> Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
> Reviewed by: David Pacheco <dap at joyent.com>
>
> modified:
> usr/src/lib/libdtrace/common/dt_aggregate.c
> usr/src/lib/libdtrace/common/dt_cc.c
> usr/src/lib/libdtrace/common/dt_consume.c
> usr/src/lib/libdtrace/common/dt_errtags.h
> usr/src/lib/libdtrace/common/dt_impl.h
> usr/src/lib/libdtrace/common/dt_open.c
> usr/src/lib/libdtrace/common/dt_pragma.c
> usr/src/lib/libdtrace/common/dt_printf.c
> usr/src/lib/libdtrace/common/dtrace.h
> usr/src/pkg/manifests/system-dtrace-tests.mf
> usr/src/uts/common/dtrace/dtrace.c
> usr/src/uts/common/sys/dtrace.h
> added:
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTOREVEN.nodivide.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTOREVEN.notfactor.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTORMATCH.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTORNSTEPS.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTORSMALL.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTORTYPE.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTORVAL.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_HIGHMATCH.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_HIGHTYPE.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_HIGHVAL.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_LOWMATCH.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_LOWTYPE.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_LOWVAL.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_MAGRANGE.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_MAGTOOBIG.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_NSTEPMATCH.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_NSTEPTYPE.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_NSTEPVAL.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.bases.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.bases.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.basic.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.basic.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negorder.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negorder.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negvalue.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negvalue.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.normal.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.normal.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.range.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.range.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.steps.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.steps.d.out
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.trunc.d
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.trunc.d.out
>
>
> changeset: 13356:4d8d96e5581b
> tag: 13356.diff
> user: Bryan Cantrill <bryan at joyent.com>
> date: Wed Mar 09 23:33:10 2011 -0800
>
> description:
> 789 dtrace may drop instructions when rapidly signalled
> Reviewed by: Robert Mustacchi <robert.mustacchi at joyent.com>
> Reviewed by: David Pacheco <dap at joyent.com>
>
> modified:
> usr/src/uts/i86pc/os/dtrace_subr.c
>
>
> changeset: 13357:e3e0f509aea1
> tag: 13357.diff
> tag: qtip
> tag: tip
> user: Richard Lowe <richlowe at richlowe.net>
> date: Wed Apr 20 01:14:34 2011 -0400
>
> description:
> 940 llquantize() dreams of JNI
> Reviewed by: Albert Lee <trisk at opensolaris.org>
> Reviewed by: Gordon Ross <gwr at nexenta.com>
>
> modified:
> usr/src/cmd/dtrace/test/cmd/jdtrace/JDTrace.java
> usr/src/cmd/dtrace/test/tst/common/java_api/src/TestBean.java
> usr/src/cmd/dtrace/test/tst/common/java_api/tst.Bean.ksh.out
> usr/src/lib/libdtrace_jni/common/dtj_consume.c
> usr/src/lib/libdtrace_jni/common/dtj_jnitab.c
> usr/src/lib/libdtrace_jni/common/dtrace_jni.h
> usr/src/lib/libdtrace_jni/java/Makefile
> usr/src/pkg/manifests/developer-dtrace.mf
> added:
> usr/src/lib/libdtrace_jni/java/src/org/opensolaris/os/dtrace/LogLinearDistribution.java
>
>pbchk:
> Copyright check:
> usr/src/cmd/dtrace/test/cmd/jdtrace/JDTrace.java: no copyright
>claim for current year found
> usr/src/cmd/dtrace/test/tst/common/java_api/src/TestBean.java: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/java_api/tst.Bean.ksh.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.bases.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.basic.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negorder.d.out:
>no copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.negvalue.d.out:
>no copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.normal.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.range.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.steps.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/llquantize/tst.trunc.d.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/mdb/tst.dtracedcmd.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/misc/tst.include.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/misc/tst.macroglob.ksh.out: no
>copyright message found
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.ufunc.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.umod.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/profile-n/tst.usym.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/safety/tst.violentdeath.ksh: no
>copyright claim for current year found
> usr/src/cmd/dtrace/test/tst/common/ustack/tst.spin.ksh: no
>copyright claim for current year found
> usr/src/lib/libdtrace_jni/common/dtj_consume.c: no copyright claim
>for current year found
> usr/src/lib/libdtrace_jni/common/dtj_jnitab.c: no copyright claim
>for current year found
> usr/src/lib/libdtrace_jni/common/dtrace_jni.h: no copyright claim
>for current year found
> usr/src/lib/libdtrace_jni/java/Makefile: no copyright claim for
>current year found
> usr/src/lib/libreparse/common/fs_reparse_lib.c: no copyright claim
>for current year found
> usr/src/pkg/manifests/developer-dtrace.mf: no copyright claim for
>current year found
> usr/src/pkg/manifests/system-dtrace-tests.mf: no copyright claim
>for current year found
> usr/src/uts/common/fs/fs_reparse.h: no copyright claim for current
>year found
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
> zsh: exit 1 hg pbchk
> hg pbchk 8.25s user 1.83s system 66% cpu 15.079 total
>
>The files with non-updated copyrights are files from my changesets
>which I don't feel inclined to explicitly assert my copyright on, or
>changes to dtest output or error files which cannot contain copyright
>or license information.
>
>Testing:
>
> installed on my desktop, ran the dtrace test suite in the regular
>fashion (just ran dtest), verified that failed tests are both 1)
>failures that existed prior to these changes, 2) failures I don't
>immediately know how to fix (for those interested,
>pid/tst.newprobes.ksh is either broken or racy, and a handful of the
>network provider tests are, I believe, sensitive to the general
>network environment). I've been discussing the newprobes failure with
>ahl, but unfortunately the bug I found that I thought was responsible
>for it failing (and which Adam is fixing) turns out to be unlikely to
>be the cause of the bug itself. Joyent's changes are, as I understand
>it, also being used in their environment as part of the underpinnings
>of their cloud analytics, which would have provided real world use
>(I'm not privvy to the implementation, but it seems reasonable to
>assume that if you modify DTrace to support your product, that your
>product uses the features you added).
>
>mail message is attached.
>
>-- Rich
>
>_______________________________________________
>Advocates mailing list
>Advocates at lists.illumos.org
>http://lists.illumos.org/m/listinfo/advocates
More information about the Advocates
mailing list