[illumos-Advocates] [RTI] 1121 smbsrv should use SPNEGO (outbound authentication)

[Garrett D'Amore]

I"m reviewing:

mlsvc_client.c: line 229.  Why the XXX ?

mlsvc_client.c: line 183, 193, 240... others?  You are using
syslog(LOG_DEBUG) here.  Is that really appropriate?  Does it match
existing practice in this code?  I'm especially concerned if this winds
up in a library, rather than in application code.  There are other error
paths in this code that don't fire off a syslog() event.  (In general,
for developer debugging, I prefer dtrace or its ilk, and I try to
reserve syslog for things that need administrator attention.)

mlsvc_client.c: line 549.  Why this change?

smbrdr_glue.c: line 177. This really feels like something that should be
done via dtrace fbt provider.

With that reply, the rest of the changes look good.

	- Garrett


On Tue, 2011-07-05 at 22:55 -0400, Gordon Ross wrote:
> Final webrev:
>  http://www.yalms.org/cr/illumos-1121/
> 
> outgoing, pbchk, mail_msg (attached)
> Just one reviewer at the moment:
> Albert Lee <trisk at nexenta.com>
> 
> The mail_msg has some noise due to:
>  https://www.illumos.org/issues/1078
> but I don't see any real problems there.
> 
> Tested by joining Win2k3 and Win2k8 domains,
> authenticating with domain accounts.
> 
> On Wed, Jun 29, 2011 at 11:37 AM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> > Anyone else want to review this? Or shall I just RTI it with one reviewer?
> > (Thanks, Albert:)
> >
> >> Webrev updated, same place:
> >> http://www.yalms.org/cr/illumos-1121/
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates