[illumos-Advocates] [RTI] 1037, 1199, 1200
Richard Lowe
richlowe at richlowe.net
Wed Jul 13 18:43:16 PDT 2011
outgoing:
comparing with /builds/illumos-clone
searching for changes
changeset: 13399:c54a0461740c
user: Richard Lowe <richlowe at richlowe.net>
date: Mon May 16 01:22:14 2011 +0100
description:
1037 bfe references random 'halt' symbol
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
modified:
usr/src/uts/common/io/bfe/bfe.c
changeset: 13400:046df1d7f2b7
user: Richard Lowe <richlowe at richlowe.net>
date: Mon May 16 01:24:15 2011 +0100
description:
1199 efe_restart should be as static as its prototype
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
modified:
usr/src/uts/common/io/efe/efe.c
changeset: 13401:2fd5efc3535e
tag: tip
user: Richard Lowe <richlowe at richlowe.net>
date: Wed Jun 22 10:37:21 2011 -0700
description:
1200 various modules declare static functions within function bodies
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Gordon Ross <gwr at nexenta.com>
modified:
usr/src/cmd/picl/plugins/sun4u/snowbird/frutree/piclkstat.c
usr/src/lib/libbc/libc/gen/common/usleep.c
usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c
usr/src/uts/i86pc/io/dr/dr.c
usr/src/uts/sun4u/cpu/opl_kdi.c
usr/src/uts/sun4u/ngdr/io/dr.c
usr/src/uts/sun4u/opl/io/drmach.c
usr/src/uts/sun4u/os/fillsysinfo.c
usr/src/uts/sun4u/serengeti/io/sbdp_cpu.c
usr/src/uts/sun4u/starcat/io/drmach.c
usr/src/uts/sun4u/starfire/io/drmach.c
usr/src/uts/sun4u/sunfire/io/fhc.c
pbchk:
Copyright check:
usr/src/cmd/picl/plugins/sun4u/snowbird/frutree/piclkstat.c: no
copyright claim for current year found
usr/src/lib/libbc/libc/gen/common/usleep.c: no copyright claim for
current year found
usr/src/uts/common/io/bfe/bfe.c: no copyright claim for current year found
usr/src/uts/common/io/efe/efe.c: no copyright claim for current year found
usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c: no copyright
claim for current year found
usr/src/uts/i86pc/io/dr/dr.c: no copyright claim for current year found
usr/src/uts/sun4u/cpu/opl_kdi.c: no copyright claim for current year found
usr/src/uts/sun4u/ngdr/io/dr.c: no copyright claim for current year found
usr/src/uts/sun4u/opl/io/drmach.c: no copyright claim for current year found
usr/src/uts/sun4u/os/fillsysinfo.c: no copyright claim for current
year found
usr/src/uts/sun4u/serengeti/io/sbdp_cpu.c: no copyright claim for
current year found
usr/src/uts/sun4u/starcat/io/drmach.c: no copyright claim for
current year found
usr/src/uts/sun4u/starfire/io/drmach.c: no copyright claim for
current year found
usr/src/uts/sun4u/sunfire/io/fhc.c: no copyright claim for current
year found
C style check:
usr/src/lib/libbc/libc/gen/common/usleep.c: 48: missing space
around relational operator
Header format check:
Java style check:
Mapfile comment check:
File permission check:
Keywords check:
Comments check:
Checking for new tags:
Checking for multiple heads (or branches):
Checking for branch changes:
Checking for uncommitted changes:
Checking for merges:
The cstyle noise is due to a macro being used to paste an operator
(and pre-exists), the alternatives don't really seem any more
attractive to me (I want to think I remember them being differently
noisy, but I'm not sure).
testing:
I want to push my luck and claim obviousness, due to the amount of
hardware involved (and the fact I have none of it, and I think on the
SPARC side, none of the rest of us do either) and the nature of the
changes.
wsdiff reports that efe is unchanged, dr* change in a pattern like this:
< drmach_board_dispose+0x6f: ba 47 02 00 00 movl $0x247,%edx
---
> drmach_board_dispose+0x6f: ba 53 02 00 00 movl $0x253,%edx
And similar (the same on SPARC, but mov to %o0 rather than movl to
%edx of course), presumably because the prototype movement tickled the
generated code slightly.
bfe is unfortunately much more noisy, because the consequent of the
condition from which the 'halt == 0' was removed was previously dead
(since halt is a function).
Mail messages are inline below (apologies for the runtime noise,
workspace re-use. They stem from Gordon's recent changes).
-- Rich
==== Nightly distributed build started: Wed Jul 13 06:27:33 BST 2011 ====
==== Nightly distributed build completed: Wed Jul 13 08:06:13 BST 2011 ====
==== Total build time ====
real 1:38:39
==== Build environment ====
i386:
/usr/bin/uname
SunOS richlowe.openindiana.org 5.11 oi_148 i86pc i386 i86pc
/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
number of concurrent jobs = 16
32-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/onnv-tools/SUNWspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
64-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/onnv-tools/SUNWspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
/usr/java/bin/javac
java full version "1.6.0_21-b06"
/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1725
Build project: build
Build taskid: 1599
==== Nightly argument issues ====
==== Build version ====
illumos-richlowe_67
==== Make clobber ERRORS ====
==== Make tools clobber ERRORS ====
==== Tools build errors ====
==== Build errors (non-DEBUG) ====
==== Build warnings (non-DEBUG) ====
==== Elapsed build time (non-DEBUG) ====
real 34:19.1
user 3:40:41.6
sys 51:46.4
==== Build noise differences (non-DEBUG) ====
==== package build errors (non-DEBUG) ====
==== Build errors (DEBUG) ====
==== Build warnings (DEBUG) ====
==== Elapsed build time (DEBUG) ====
real 30:26.0
user 3:07:41.9
sys 40:59.8
==== Build noise differences (DEBUG) ====
==== package build errors (DEBUG) ====
==== Validating manifests against proto area ====
==== Check ELF runtime attributes ====
==== Diff ELF runtime attributes (since last build) ====
26556a26557
> usr/lib/smbsrv/amd64/libmlsvc.so.1: NEEDED=libsmbfs.so.1
26558d26558
< usr/lib/smbsrv/amd64/libmlsvc.so.1: NEEDED=libsmbrdr.so.1
26607,26617d26606
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: NEEDED=libc.so.1
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: NEEDED=libnsl.so.1
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: NEEDED=libsmb.so.1
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: NEEDED=libsocket.so.1
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: RPATH=/usr/lib/smbsrv/amd64
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERDEF=libsmbrdr.so.1 [BASE]
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_DYNAMIC
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERSION=libsmbrdr.so.1,
SYMBOL=_PROCEDURE_LINKAGE_TABLE_
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_edata
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_end
< usr/lib/smbsrv/amd64/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_etext
26641a26631
> usr/lib/smbsrv/libmlsvc.so.1: NEEDED=libsmbfs.so.1
26643d26632
< usr/lib/smbsrv/libmlsvc.so.1: NEEDED=libsmbrdr.so.1
26696,26707d26684
< usr/lib/smbsrv/libsmbrdr.so.1: NEEDED=libc.so.1
< usr/lib/smbsrv/libsmbrdr.so.1: NEEDED=libnsl.so.1
< usr/lib/smbsrv/libsmbrdr.so.1: NEEDED=libsmb.so.1
< usr/lib/smbsrv/libsmbrdr.so.1: NEEDED=libsocket.so.1
< usr/lib/smbsrv/libsmbrdr.so.1: RPATH=/usr/lib/smbsrv
< usr/lib/smbsrv/libsmbrdr.so.1: VERDEF=libsmbrdr.so.1 [BASE]
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_DYNAMIC
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1,
SYMBOL=_GLOBAL_OFFSET_TABLE_
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1,
SYMBOL=_PROCEDURE_LINKAGE_TABLE_
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_edata
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_end
< usr/lib/smbsrv/libsmbrdr.so.1: VERSION=libsmbrdr.so.1, SYMBOL=_etext
==== 'dmake lint' of src ERRORS ====
==== Elapsed time of 'dmake lint' of src ====
real 19:12.9
user 1:04:09.0
sys 15:02.6
==== lint warnings src ====
==== lint noise differences src ====
==== cstyle/hdrchk errors ====
==== Find core files ====
==== Diff unreferenced files (since last build) ====
3419,3420d3418
< ./usr/src/lib/smbsrv/libsmbrdr/sparc/Makefile
< ./usr/src/lib/smbsrv/libsmbrdr/sparcv9/Makefile
==== Check lists of files ====
==== Impact on file permissions ====
sparc:
==== Nightly distributed build started: Wed Jul 13 13:11:14 PDT 2011 ====
==== Nightly distributed build completed: Wed Jul 13 17:29:44 PDT 2011 ====
==== Total build time ====
real 4:18:30
==== Build environment ====
/usr/bin/uname
SunOS richlowe 5.11 oi_147 sun4v sparc SUNW,Sun-Fire-T1000
/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_sparc Patch 126503-01 2007/07/19
number of concurrent jobs = 64
32-bit compiler
/opt/onbld/bin/sparc/cw -_cc
cw version 1.29
primary: /opt/onnv-tools/SUNWspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_sparc Patch 124867-11 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
64-bit compiler
/opt/onbld/bin/sparc/cw -_cc
cw version 1.29
primary: /opt/onnv-tools/SUNWspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_sparc Patch 124867-11 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
/usr/java/bin/javac
java full version "1.6.0_18-b07"
/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_sparc snv_121 08/03/2009
/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1725
Build project: group.staff
Build taskid: 593
==== Nightly argument issues ====
==== Build version ====
gcc/syntax-0-g57e333b
==== Make clobber ERRORS ====
==== Make tools clobber ERRORS ====
==== Tools build errors ====
==== Build errors (DEBUG) ====
==== Build warnings (DEBUG) ====
==== Elapsed build time (DEBUG) ====
real 2:25:01.3
user 41:41:34.1
sys 4:25:52.3
==== Build noise differences (DEBUG) ====
==== package build errors (DEBUG) ====
==== Validating manifests against proto area ====
==== Check ELF runtime attributes ====
==== Diff ELF runtime attributes (since last build) ====
==== 'dmake lint' of src ERRORS ====
==== Elapsed time of 'dmake lint' of src ====
real 1:06:46.5
user 7:35:43.1
sys 1:17:34.3
==== lint warnings src ====
==== lint noise differences src ====
==== cstyle/hdrchk errors ====
==== Find core files ====
==== Check lists of files ====
==== Impact on file permissions ====
More information about the Advocates
mailing list