[illumos-Advocates] [RTI] 1222-1224, 1230 constant string overwrites and GCC4.x stdarg

[Garrett D'Amore]

I'll look shortly.

	- Garrett

On Mon, 2011-07-25 at 16:32 -0400, Richard Lowe wrote:
> I'd prefer an advocate who wasn't one of only two reviewers for 3 of
> these, if anyone is willing.
> 
> -- Rich
> 
> 
> 
> On Sat, Jul 23, 2011 at 21:05, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> > I think you've been thorough enough.  I say "push it".
> >
> > On Sat, Jul 23, 2011 at 4:50 PM, Richard Lowe <richlowe at richlowe.net> wrote:
> >>
> >> outgoing:
> >>    comparing with /builds/illumos-clone
> >>    searching for changes
> >>
> >>    changeset:   13410:887780fcf2f5
> >>    user:        Richard Lowe <richlowe at richlowe.net>
> >>    date:        Mon Jun 27 18:29:43 2011 +0100
> >>
> >>    description:
> >>        1224 lp may overwrite constant data
> >>        Reviewed by: Gordon Ross <gwr at nexenta.com>
> >>        Reviewed by: Albert Lee <trisk at nexenta.com>
> >>
> >>    modified:
> >>       usr/src/cmd/lp/cmd/lpadmin/options.c
> >>       usr/src/cmd/lp/cmd/lpfilter.c
> >>       usr/src/cmd/lp/cmd/lpforms.c
> >>       usr/src/cmd/lp/cmd/lpusers.c
> >>       usr/src/cmd/lp/lib/lp/isterminfo.c
> >>       usr/src/cmd/lp/lib/lp/tidbit.c
> >>
> >>
> >>    changeset:   13411:23161d58e78a
> >>    user:        Richard Lowe <richlowe at richlowe.net>
> >>    date:        Thu Jun 16 07:46:34 2011 +0100
> >>
> >>    description:
> >>        1223 catman may modify constant data
> >>        Reviewed by: Gordon Ross <gwr at nexenta.com>
> >>        Reviewed by: Albert Lee <trisk at nexenta.com>
> >>
> >>    modified:
> >>       usr/src/cmd/man/src/man.c
> >>
> >>
> >>    changeset:   13412:b5ca1dcc04d2
> >>    user:        Richard Lowe <richlowe at richlowe.net>
> >>    date:        Wed Jun 15 13:30:14 2011 +0100
> >>
> >>    description:
> >>        1222 crypt may modify constant data
> >>        Reviewed by: Gordon Ross <gwr at nexenta.com>
> >>        Reviewed by: Albert Lee <trisk at nexenta.com>
> >>
> >>    modified:
> >>       usr/src/cmd/crypt/crypt.c
> >>
> >>
> >>    changeset:   13413:862e53600e55
> >>    tag:         tip
> >>    user:        Richard Lowe <richlowe at richlowe.net>
> >>    date:        Mon May 16 00:20:30 2011 +0100
> >>
> >>    description:
> >>        1230 need support for recent gcc stdarg builtins
> >>        1240 va_*.h use non-existent __GNUC_MINOR
> >>        Reviewed by: Alexander Eremin <alexander.eremin at nexenta.com>
> >>        Reviewed by: Jason King <jason.brian.king at gmail.com>
> >>        Reviewed by: Gordon Ross <gwr at nexenta.com>
> >>        Reviewed by: Garret D'Amore <garrett at nexenta.com>
> >>
> >>    modified:
> >>       usr/src/uts/common/sys/va_impl.h
> >>       usr/src/uts/common/sys/va_list.h
> > [...]
> >
> 
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates