[illumos-Advocates] RTI 734 taskq_dispatch_prealloc() desired

Garrett D'Amore garrett at damore.org
Tue Jul 26 12:07:56 PDT 2011


(Sorry if you've already seen this ... I'm having email challenges.)

This fixes two problems:

	734 taskq_dispatch_prealloc() desired
	943 zio_interrupt ends up calling taskq_dispatch with TQ_SLEEP

garrett at thinkpad{34}> hg outgoing -v
running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
comparing with ssh://anonhg@hg.illumos.org/illumos-gate
searching for changes

changeset:   13408:5c2cdac993c6
tag:         tip
user:        Garrett D'Amore <garrett at nexenta.com>
date:        Tue Jul 26 11:03:28 2011 -0700

description:
	734 taskq_dispatch_prealloc() desired
	943 zio_interrupt ends up calling taskq_dispatch with TQ_SLEEP
	Reviewed by: Albert Lee <trisk at nexenta.com>
	Reviewed by: Richard Lowe <richlowe at richlowe.net>
	Reviewed by: Alexey Zaytsev <alexey.zaytsev at nexenta.com>
	Reviewed by: Jason Brian King <jason.brian.king at gmail.com>
	Reviewed by: George Wilson <gwilson at zfsmail.com>
	Reviewed by: Adam Leventhal <ahl at delphix.com>

modified:
   usr/src/lib/libzpool/common/sys/zfs_context.h
   usr/src/lib/libzpool/common/taskq.c
   usr/src/uts/common/fs/zfs/spa.c
   usr/src/uts/common/fs/zfs/sys/zfs_context.h
   usr/src/uts/common/fs/zfs/sys/zio.h
   usr/src/uts/common/fs/zfs/zio.c
   usr/src/uts/common/os/taskq.c
   usr/src/uts/common/sys/taskq_impl.h

Testing:

This has been heavily tested and performance regression tested using
some large configurations here at Nexenta. Also, I've verified zfstest
continues to work properly.

garrett at thinkpad{36}>  hg pbchk
Copyright check:

C style check:

Header format check:

Java style check:

Mapfile comment check:

File permission check:

Keywords check:

Comments check:

Checking for new tags:

Checking for multiple heads (or branches):

Checking for branch changes:

Checking for uncommitted changes:

Checking for merges:

garrett at thinkpad{37}> cat ../../log/log.2011-07-18.19:02/mail_msg

==== Nightly distributed build started:   Mon Jul 18 16:51:07 PDT 2011
====
==== Nightly distributed build completed: Mon Jul 18 19:02:18 PDT 2011
====

==== Total build time ====

real    2:11:11

==== Build environment ====

/usr/bin/uname
SunOS thinkpad 5.11 taskq i86pc i386 i86pc

/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
number of concurrent jobs = 10

32-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)

64-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)

/usr/java/bin/javac
java full version "1.6.0_21-b06"

/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009

/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726

Build project:  group.staff
Build taskid:   152

==== Nightly argument issues ====


==== Build version ====

taskq

==== Make clobber ERRORS ====


==== Make tools clobber ERRORS ====


==== Tools build errors ====


==== Build errors (DEBUG) ====


==== Build warnings (DEBUG) ====


==== Elapsed build time (DEBUG) ====

real  1:15:46.9
user  6:41:19.2
sys   1:22:02.0

==== Build noise differences (DEBUG) ====


==== package build errors (DEBUG) ====


==== Validating manifests against proto area ====


==== Check ELF runtime attributes ====


==== Diff ELF runtime attributes (since last build) ====


==== 'dmake lint' of src ERRORS ====


==== Elapsed time of 'dmake lint' of src ====

real    36:14.3
user  1:38:43.5
sys   1:20:29.3

==== lint warnings src ====


==== lint noise differences src ====


==== cstyle/hdrchk errors ====


==== Find core files ====


==== Check lists of files ====


==== Impact on file permissions ====






More information about the Advocates mailing list