[illumos-Advocates] [semi-RTI] I broke incremental builds with the manual page wad, ok a followup?

[Garrett D'Amore]

On Tue, 2011-03-22 at 02:33 -0400, Richard Lowe wrote:
> A typo in the manual page wad broke incremental builds (I'm not quite
> sure how I'm the first to notice this?)

Neither am I, but the last couple of builds I've done have been full, as
I prefer to use full builds before filing an RTI. :-)

> 
> I'd like approval to integrate the following diff as a (fix
> incremental) followup, the important change is the missing '/' after
> $(ROOTMAN)
> 
> changeset:   13311:de40bba6236d
> tag:         man-incr-fix
> tag:         qbase
> tag:         qtip
> tag:         tip
> user:        Richard Lowe <richlowe at richlowe.net>
> date:        Tue Mar 22 02:27:11 2011 -0400
> 
> description:
> 	243 system manual pages should live with the software (fix incremental)
> 
> modified:
>    usr/src/man/man3perl/Makefile
> 
> I'm running an incremental now to double check, full builds won't
> notice as the clobber will blow away the (unwritable) destination
> files, but I will run one before I integrate.

Approved.  Please integrate this asap, and thanks for following up.

	- Garrett

> 
> -- Rich
> 
> diff --git a/usr/src/man/man3perl/Makefile b/usr/src/man/man3perl/Makefile
> --- a/usr/src/man/man3perl/Makefile
> +++ b/usr/src/man/man3perl/Makefile
> @@ -43,10 +43,10 @@
>  # As a workaround, install the files manually in a FRC target.
>  CMD= $(INS) -s -m $(FILEMODE) -f $(ROOTMAN)/man$(MANSECT)
>  install: FRC
> -	@for file in $(MANFILES); do				\
> -		if [[ $$file -nt $(ROOTMAN)/man$(MANSECT)/$$file ]]; then	\
> +	@for file in $(MANFILES); do					\
> +		if [[ $$file -nt $(ROOTMAN)/man$(MANSECT)/$$file ]]; then \
>  			$(ECHO) $(CMD) $$file;				\
> -			$(RM) $(ROOTMAN)man$(MANSECT)/$$file;			\
> +			$(RM) $(ROOTMAN)/man$(MANSECT)/$$file;		\
>  			$(CMD) $$file;					\
>  		fi							\
>  	done;
> 
> -- Rich
> 
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates