[illumos-Advocates] RTI 643 date -R support would be helpful
Garrett D'Amore
garrett at damore.org
Mon May 2 10:42:56 PDT 2011
garrett at thinkpad{86}> hg outgoing -v
running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
comparing with ssh://anonhg@hg.illumos.org/illumos-gate
searching for changes
changeset: 13359:1c61ee20a3e1
tag: tip
user: Garrett D'Amore <garrett at nexenta.com>
date: Mon May 02 09:38:29 2011 -0700
description:
643 date -R support would be helpful
Reviewed by: Jason King <jason.brian.king at gmail.com>
Reviewed by: Yuri Pankov <yuri.pankov at nexenta.com>
Reviewed by: Dan McDonald <danmcd at nexenta.com>
Reviewed by: Kartik Mistry <kartik at nexenta.com>
Reviewed by: Rich Lowe <richlowe at richlowe.net>
modified:
usr/src/cmd/date/date.c
usr/src/man/man1/date.1
I tested this trivially using date -R and comparing the output against
Ubuntu Natty Narwhal. I also did test the formatting of the man page for
correctness. I also did a basic regression test, and I tested both the
xpg4 and original variant. (Interestingly enough, I think I've detected
a bug in strftime -- it behaves as XPG4 all the time, and doesn't handle
the legacy formats that it should. I'll be filing bugs against
that. :-)
I did two very trivial whitespace changes to other areas of date.c
(indent tweaks) to make it compliant with cstyle. (Our cstyle is more
stringent than it used to be.) I didn't bother to have those reviewed.
hg pbchk is clean now:
garrett at thinkpad{15}> hg pbchk
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
Copyright check:
C style check:
Header format check:
Java style check:
Mapfile comment check:
File permission check:
Keywords check:
Comments check:
Checking for new tags:
Checking for multiple heads (or branches):
Checking for branch changes:
Checking for uncommitted changes:
Checking for merges:
Here's the nightly build log:
garrett at thinkpad{18}> cat log/log.2011-05-02.01:14/mail_msg
==== Nightly distributed build started: Sun May 1 23:14:02 PDT 2011
====
==== Nightly distributed build completed: Mon May 2 01:14:06 PDT 2011
====
==== Total build time ====
real 2:00:03
==== Build environment ====
/usr/bin/uname
SunOS thinkpad 5.11 qlc2322 i86pc i386 i86pc
/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
number of concurrent jobs = 10
32-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
64-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
/usr/java/bin/javac
java full version "1.6.0_21-b06"
/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726
Build project: group.staff
Build taskid: 129
==== Nightly argument issues ====
==== Build version ====
date-r
==== Make clobber ERRORS ====
==== Make tools clobber ERRORS ====
==== Tools build errors ====
==== Build errors (DEBUG) ====
==== Build warnings (DEBUG) ====
==== Elapsed build time (DEBUG) ====
real 1:16:06.2
user 6:42:13.9
sys 1:20:30.3
==== Build noise differences (DEBUG) ====
==== package build errors (DEBUG) ====
==== Validating manifests against proto area ====
==== Check ELF runtime attributes ====
==== Diff ELF runtime attributes (since last build) ====
==== 'dmake lint' of src ERRORS ====
==== Elapsed time of 'dmake lint' of src ====
real 30:11.8
user 1:37:10.4
sys 46:26.1
==== lint warnings src ====
==== lint noise differences src ====
==== cstyle/hdrchk errors ====
==== Find core files ====
==== Check lists of files ====
==== Impact on file permissions ====
More information about the Advocates
mailing list