[illumos-Advocates] RTI https://www.illumos.org/issues/696
Garrett D'Amore
garrett at damore.org
Fri May 6 23:16:43 PDT 2011
webrev here: http://mexico.purplecow.org/gdamore/webrev/sgllen/
garrett at thinkpad{25}> hg outgoing -v
running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
comparing with ssh://anonhg@hg.illumos.org/illumos-gate
searching for changes
changeset: 13364:3a98c348a826
tag: tip
user: Garrett D'Amore <garrett at nexenta.com>
date: Fri May 06 21:42:56 2011 -0700
description:
696 Incorrect check dma_attr_sgllen <= 0 in rootnex_valid_alloc_parms
modified:
usr/src/uts/i86pc/io/rootnex.c
hg pbchk:
garrett at thinkpad{26}> hg pbchk
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc
from untrusted user hg, group hg
Copyright check:
C style check:
Header format check:
Java style check:
Mapfile comment check:
File permission check:
Keywords check:
Comments check:
Checking for new tags:
Checking for multiple heads (or branches):
Checking for branch changes:
Checking for uncommitted changes:
Checking for merges:
No full nightly, but an incremental came back clean (log attached, note
the proto warnings were from closed bits because I naively used cp -r
instead of untarring the closed tarball). I've also supplemented that
with dmake lint in usr/src/uts (after bldenv -d) to make sure that I
didn't introduce any lint errors. It came back clean.
Testing: To test this, I loaded these bits on a debug system (Thinkpad
W510), using the debug kernel, verified that the debug checks were
present, then also tested with a modified e1000g with the following
change (which I'm *not* committing, this was just for test):
diff -r ef9e6008c21c usr/src/uts/common/io/e1000g/e1000g_alloc.c
--- a/usr/src/uts/common/io/e1000g/e1000g_alloc.c Fri May 06
10:04:21 2011 -0700
+++ b/usr/src/uts/common/io/e1000g/e1000g_alloc.c Fri May 06
23:12:17 2011 -0700
@@ -107,7 +107,7 @@
1, /* minimum transfer */
0xffffffffU, /* maximum transfer */
0xffffffffffffffffULL, /* maximum segment length */
- MAX_COOKIES, /* maximum number of segments */
+ -1, /* maximum number of segments */
1, /* granularity */
DDI_DMA_FLAGERR, /* dma_attr_flags */
};
The code seems to work well, and no issues have been noticed.
-------------- next part --------------
==== Nightly distributed build started: Fri May 6 15:40:00 PDT 2011 ====
==== Nightly distributed build completed: Fri May 6 15:54:03 PDT 2011 ====
==== Total build time ====
real 0:14:02
==== Build environment ====
/usr/bin/uname
SunOS thinkpad 5.11 locale2 i86pc i386 i86pc
/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
number of concurrent jobs = 10
32-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
64-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/SUNWspro/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
/usr/java/bin/javac
java full version "1.6.0_21-b06"
/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726
Build project: group.staff
Build taskid: 184
==== Nightly argument issues ====
==== Build version ====
zfs-vdev
==== Tools build errors ====
==== Build errors (DEBUG) ====
==== Build warnings (DEBUG) ====
==== Elapsed build time (DEBUG) ====
real 8:01.2
user 29:41.6
sys 5:51.0
==== package build errors (DEBUG) ====
==== Validating manifests against proto area ====
Entries present in proto area but not manifests:
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_COLLATE
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_CTYPE
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_MESSAGES
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_MONETARY
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_NUMERIC
dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX/LC_TIME
file usr/lib/locale/POSIX/locale_description group=group mode=0444 owner=owner path=usr/lib/locale/POSIX/locale_description
Entries that differ between manifests and proto area:
manifests hardlink path=kernel/strmod/amd64/sdpib target=kernel/drv/amd64/sdpib
proto area file kernel/strmod/amd64/sdpib group=group mode=0755 owner=owner path=kernel/strmod/amd64/sdpib
manifests hardlink path=kernel/strmod/sdpib target=kernel/drv/sdpib
proto area file kernel/strmod/sdpib group=group mode=0755 owner=owner path=kernel/strmod/sdpib
manifests hardlink path=platform/i86pc/kernel/cpu/amd64/cpu_ms.GenuineIntel.6.47 target=platform/i86pc/kernel/cpu/amd64/cpu_ms.GenuineIntel.6.46
proto area file platform/i86pc/kernel/cpu/amd64/cpu_ms.GenuineIntel.6.47 group=group mode=0755 owner=owner path=platform/i86pc/kernel/cpu/amd64/cpu_ms.GenuineIntel.6.47
manifests hardlink path=platform/i86pc/kernel/cpu/cpu_ms.GenuineIntel.6.47 target=platform/i86pc/kernel/cpu/cpu_ms.GenuineIntel.6.46
proto area file platform/i86pc/kernel/cpu/cpu_ms.GenuineIntel.6.47 group=group mode=0755 owner=owner path=platform/i86pc/kernel/cpu/cpu_ms.GenuineIntel.6.47
manifests link path=usr/lib/fwflash/verify/ses-LSILOGIC.so target=ses-SUN.so
proto area file usr/lib/fwflash/verify/ses-LSILOGIC.so group=group mode=0755 owner=owner path=usr/lib/fwflash/verify/ses-LSILOGIC.so
manifests link path=usr/lib/fwflash/verify/sgen-LSILOGIC.so target=ses-SUN.so
proto area file usr/lib/fwflash/verify/sgen-LSILOGIC.so group=group mode=0755 owner=owner path=usr/lib/fwflash/verify/sgen-LSILOGIC.so
manifests link path=usr/lib/fwflash/verify/sgen-SUN.so target=ses-SUN.so
proto area file usr/lib/fwflash/verify/sgen-SUN.so group=group mode=0755 owner=owner path=usr/lib/fwflash/verify/sgen-SUN.so
manifests link path=usr/lib/locale/POSIX target=C
proto area dir group=group mode=0755 owner=owner path=usr/lib/locale/POSIX
==== Check ELF runtime attributes ====
==== Diff ELF runtime attributes (since last build) ====
==== Find core files ====
==== Check lists of files ====
==== Impact on file permissions ====
More information about the Advocates
mailing list