[illumos-Advocates] RTI https://www.illumos.org/issues/696

[Garrett D'Amore]

That would be a bug... wd cookie count should always be a reasonably small positive number.

Dan McDonald <danmcd at nexenta.com> wrote:

>On Sat, May 07, 2011 at 03:23:09PM -0400, Richard Lowe wrote:
>> Sounded to me like Dan wanted more time.  So I'm giving it to him (I'm
>> not sure where we'd find rootnex experience, off the top of my head
>> though)
>
>Okay, I've looked through it some more.
>
>Garrett's changes look okay.  This line:
>
>2179             (sinfo->si_sgl_size <= (unsigned)attr->dma_attr_sgllen) &&
>
>will evaluate always-true with the default value of "-1".  I expect this to
>be a feature, and save the check per the comment.
>
>One potential problem:
>
>3396                 } else if (window->wd_cookie_cnt >=
>3397                     (unsigned)attr->dma_attr_sgllen) {
>
>What if wd_cookie_cnt is 0xffffffff?  You will end up taking this path.  Not
>sure if THIS is a bug or a feature.
>
>Dan
>
>_______________________________________________
>Advocates mailing list
>Advocates at lists.illumos.org
>http://lists.illumos.org/m/listinfo/advocates