[illumos-Advocates] RTI: 742 Resurrect the ZFS "aclmode" property (and 664, 279)

[Gordon Ross]

I was tempted to add Mark Shellenbaum, because he did look at it,
but his only feedback was "[fix for 807] will cause problems".
We backed that part out, but never got an "OK" from him.
So if we list his name, we're saying silence is assent.
Everyone OK with that?

I searched my email, and I don't see a review from anyone
named Lisa.  Do you have an email from her?

Thanks,
Gordon

On Fri, May 13, 2011 at 9:42 PM, Garrett D'Amore <garrett at nexenta.com> wrote:
> Please add Mark Shellenbaum and Lisa (dont remember her name) to your list of reviewers.  Hopefully you have the review feedback.  Also, please delete the empty line in ypur comments.
>
>  -- Garrett D'Amore
>
> On May 13, 2011, at 4:01 PM, "Gordon Ross" <Gordon.Ross at nexenta.com> wrote:
>
>> Request to integrate (see below).
>>
>>> OK, not having heard any objections, I think the aclmode work
>>> is ready to integrate.  I'm planning an RTI for this today.
>>> Change set description below.  Webrev in the quoted text.
>>> Last chance, zfs-wg!  Going, going, ...
>> ......................................... gone!
>>
>>
>> Output of "hg outgoing -v" here.
>> Other details in attachments.
>>
>> comparing with /tank/ws/illumos-clone
>> searching for changes
>>
>> changeset:   13350:e2bf8d3e83db
>> tag:         tip
>> user:        Albert Lee <trisk at opensolaris.org>
>> date:        Fri May 13 10:59:00 2011 -0400
>>
>> description:
>>    742 Resurrect the ZFS "aclmode" property
>>    664 Umask masking "deny" ACL entries.
>>    279 Bug in the new ACL (post-PSARC/2010/029) semantics
>>
>>    Reviewed by: Aram Hăvărneanu <aram at nexenta.com>
>>    Reviewed by: Gordon Ross <gwr at nexenta.com>
>>    Reviewed by: Robert Gordon <rbg at openrbg.com>
>>    Approved by: Garrett D'Amore <garrett at nexenta.com>
>>
>> modified:
>>   usr/src/common/acl/acl_common.c
>>   usr/src/common/acl/acl_common.h
>>   usr/src/common/zfs/zfs_prop.c
>>   usr/src/lib/libsec/common/aclutils.c
>>   usr/src/lib/libzfs_jni/common/libzfs_jni_property.c
>>   usr/src/man/man1m/zfs.1m
>>   usr/src/uts/common/fs/fs_subr.c
>>   usr/src/uts/common/fs/zfs/sys/zfs_acl.h
>>   usr/src/uts/common/fs/zfs/sys/zfs_vfsops.h
>>   usr/src/uts/common/fs/zfs/zfs_acl.c
>>   usr/src/uts/common/fs/zfs/zfs_vfsops.c
>>   usr/src/uts/common/fs/zfs/zfs_vnops.c
>>   usr/src/uts/common/sys/fs/zfs.h
>>
>>
>> <pbchk.txt>
>> <mail_msg.txt>
>> <aclmode-tests.txt>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>