[illumos-Advocates] RTI: 1039 /usr/lib/smbsrv/smbd prevents suspend

[Gordon Ross]

Minor update (parens added _spool.c:172) for
review feedback by Rich Lowe.  Updated the
webrev, same location as before.

New outgoing:

comparing with /tank/ws/illumos-clone
searching for changes

changeset:   13378:7fda4712e50d
tag:         tip
user:        Gordon Ross <gwr at nexenta.com>
date:        Fri May 27 17:03:53 2011 -0400

description:
	1039 /usr/lib/smbsrv/smbd prevents suspend
	Reviewed by: Eric Schrock <eric.schrock at delphix.com>
	Reviewed by: Richard Lowe <richlowe at richlowe.net>
	Approved by: ?

modified:
   usr/src/cmd/smbsrv/smbd/smbd_spool.c
   usr/src/uts/common/fs/smbsrv/smb_print.c
   usr/src/uts/common/fs/smbsrv/smb_server.c
   usr/src/uts/common/smbsrv/smb_kproto.h
   usr/src/uts/common/smbsrv/smb_ktypes.h


On Fri, May 27, 2011 at 4:06 PM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> webrev:
>  http://www.yalms.org/cr/illumos-1039/
>
> BTW, this bug prevents not only suspend, but also
> zone shutdown (multi-zone support in progress:)
> because smbd can't be killed.
>
> hg outgoing:
> comparing with /tank/ws/illumos-clone
> searching for changes
>
> changeset:   13378:5c807af94b91
> tag:         tip
> user:        Gordon Ross <gwr at nexenta.com>
> date:        Fri May 27 15:57:01 2011 -0400
>
> description:
>        1039 /usr/lib/smbsrv/smbd prevents suspend
>        Reviewed by: Eric Schrock <eric.schrock at delphix.com>
>        Approved by: ?
>
> modified:
>   usr/src/cmd/smbsrv/smbd/smbd_spool.c
>   usr/src/uts/common/fs/smbsrv/smb_print.c
>   usr/src/uts/common/fs/smbsrv/smb_server.c
>   usr/src/uts/common/smbsrv/smb_kproto.h
>   usr/src/uts/common/smbsrv/smb_ktypes.h
>
> hg pbchk:
> Copyright check:
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
> Testing:
>  Configured printing (what a PITA:)
>  printed some stuff.
>  verified smbd can be killed
>  verified system suspend works.
>
> mail_msg (attached)
>