[illumos-Advocates] RTI for bug 1052: ttymon crashes in a loop when non-existent user logs out

[Richard Lowe]

I think that looks good (I think all the build noise is Studio 12.1 related).
I'll take this, re-build it, and push if it does come back clean.

-- Rich



On Tue, May 31, 2011 at 17:25, Gary Mills <mills at cc.umanitoba.ca> wrote:
> I'm attaching the `hg export' output and mail_msg from a nightly run
> with lint.
>
> Here's outgoing:
>
>    $ hg outgoing -v
>    running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
>    remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc from untrusted user hg, group hg
>    comparing with ssh://anonhg@hg.illumos.org/illumos-gate
>    searching for changes
>
>    changeset:   13378:2f2a05f5c401
>    tag:         tip
>    user:        Gary Mills <mills at cc.umanitoba.ca>
>    date:        Tue May 31 16:11:17 2011 -0500
>
>    description:
>        1052 ttymon crashes in a loop when non-existent user logs out
>        Reviewed by: Gordon Ross
>        Reviewed by: Garrett D'Amore
>
>    modified:
>       usr/src/lib/libdevinfo/devinfo_devperm.c
>
>    remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc from untrusted user hg, group hg
>
> And pbchk:
>
>    $ hg pbchk
>    remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc from untrusted user hg, group hg
>    remote: Not trusting file /export/illumos/hgrepos/illumos-gate/.hg/hgrc from untrusted user hg, group hg
>    Copyright check:
>
>    C style check:
>
>    Header format check:
>
>    Java style check:
>
>    Mapfile comment check:
>
>    File permission check:
>
>    Keywords check:
>
>    Comments check:
>
>    Checking for new tags:
>
>    Checking for multiple heads (or branches):
>
>    Checking for branch changes:
>
>    Checking for uncommitted changes:
>
>    Checking for merges:
>
> My testing was done on oi_148b.  It consisted of disabling the gdm
> login, logging in a test user on the text console, then changing that
> user's UID in the passwd file, and finally attempting to log out that
> user on the console.  Without changes, the logout did not complete,
> but `ttymon' repeatedly dumped core in /root with the same stack trace
> as in the bug report.  Undoing the passwd change allowed the logout to
> complete and stopped the core dumping.
>
> With the changed libdevinfo.so.1 in place, the logout succeeded and
> `ttymon' continued to run.  The ownership of /dev/console did change
> to the user on login, and changed back to root on logout.  There were
> no other visible effects of the shared library change.
>
> --
> -Gary Mills-        -Unix Group-        -Computer and Network Services-
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>
>