[bugs] [illumos gate - Bug #1200] various modules declare static functions within function bodies

[illumos bugs]

Issue #1200 has been updated by Alan Coopersmith.


I believe placing function prototypes in the body of functions is technically legal C, but strongly discouraged as bad style, as it leads to prototypes being out of sync in different files.   gcc similarly warns about non-static functions for which prototypes are not found from a common header file to avoid issues from prototype proliferation in calling sources.
----------------------------------------
Bug #1200: various modules declare static functions within function bodies
https://www.illumos.org/issues/1200

Author: Rich Lowe
Status: In Progress
Priority: Normal
Assignee: Rich Lowe
Category: kernel
Target version: 
Difficulty: Medium
Tags: 


It is, apparently, non-sensical to place a static function prototype within the body of a function, though Studio and GCC have supported it.

They should be pulled up to file scope.


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://www.illumos.org/my/account