[illumos-Developer] ksh93-integration update3 prototype webrev...

Jason King jason.brian.king at gmail.com
Wed Aug 4 16:41:31 PDT 2010


Perhaps this is due to my ignorance, but a sizeable number of files in
the webrev differ only in the 'generated from' comment. Ex:

http://cr.opensolaris.org/~fleyta/on_posix_utility_update2_20100801_012/usr/src/lib/libast/amd64/include/ast/ast_limits.h.patch

Is there any harm if that comment was just removed?  I get the
impression that with them present, future updates will have a
similarly set of files that are not materially changed.   For me at
least, they significantly increase the time it takes to review a
bundle.

On Wed, Aug 4, 2010 at 6:12 PM, Roland Mainz <roland.mainz at nrubsig.org> wrote:
> Hi!
>
> ----
>
> Olga uploaded a ksh93-integration update3 webrev to
> http://cr.opensolaris.org/~fleyta/on_posix_utility_update2_20100801_012/
> a few days ago... can anyone please take a quick look, please ?
>
> Notes:
> - The "tr" replacement is part of the code but { /usr/bin/tr,
> /usr/xpg4/bin/tr, /usr/xpg6/bin/tr } do not link to /usr/bin/alias
> (our busybox-like wrapper) yet
> - "od", "printf" and "tail" replacemnts are available via
> /usr/bin/alias but not linked either
> - "grep" still misses option "-r". This will be added in the next cycle.
> - Our 'tr" replacement behaves like /usr/xpg[46]/bin/tr (except option
> "-C" which still requires some work to get it a) working and b)
> working with the same performance as the Solaris "tr"). For now we
> don't try to emulate the old /usr/bin/tr because it had horrible
> multibyte handling issues (or better: It has no working multibyte
> support, the closest emulation would be to set LC_ALL='C' before using
> it) and hope noone really tries to dissect strings with multibyte
> characters at byte level with "tr".
> - The putback provides the basis for getting "sed" and "pax" replaced
> but this is not part of this putback (risk minimisation)
>
> ----
>
> Bye,
> Roland
>
> --
>   __ .  . __
>  (o.\ \/ /.o) roland.mainz at nrubsig.org
>   \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
>   /O /==\ O\  TEL +49 641 3992797
>  (;O/ \/ \O;)
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>



More information about the Developer mailing list