[illumos-Developer] Build pkg5-nightly gate, dmake install returning errors, one fix, one question

[Jon Tibble]

On 07/08/2010 22:06, Chris J. Ruwe wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 07/08/10 21:23, Mike Gerdts wrote:
>>  On Sat, Aug 7, 2010 at 2:12 PM, Chris J. Ruwe <cjr at cruwe.de> wrote:
>> >
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> >
>> > hg clone ssh://anon@hg.opensolaris.org
>> > <mailto:anon at hg.opensolaris.org>/hg/pkg/gate pkg-gate
>> > cd pkg-gate/src
>> > dmake install
>> >
>> > Following the instructions to be found in the wiki, step 3, I noticed
>> > errors which cause the 'dmake install' build to abort.
>> >
>> > 1) In gui/help/id/id.po, misplaced char in line 726, `\' instead of `
>> > ', removed -> fixed.
>> >
>> > 2) after that,
>> > msgfmt -o cs.mo cs.po
>> > cs.po:4118: `msgid' and `msgstr' entries do not bot end with `\n'.
>> > msgfmt: found 1 fatal error
>>
>>  The makefiles are flawed in that the failures generate the targets,
>>  thereby allowing repeated invocations to eventually silently ignore
>>  errors. A few days back I was compiling pkg on Linux and hacked
>>  (really, hacked) a patch together. There are cases where I changed
>>  the msgid rather than the msgstr. This primarily was done in the
>>  first few. Once I paid attention to what I was doing I started fixing
>>  only msgstr's.
>>
>>  http://cr.opensolaris.org/~mgerdts/pkg-po.patch.gz
>>
>>  I have a feeling that the difference is whether the traditional
>>  Solaris msgfmt is used or the GNU gettext equivalent.
>>
>>  $ pkg search -l msgfmt
>>  INDEX ACTION VALUE PACKAGE
>>  basename file usr/bin/msgfmt pkg:/text/locale at 0.5.11-0.143
>>  basename link usr/gnu/bin/msgfmt pkg:/text/gnu-gettext at 0.16.1-0.134
>>
>>
> Thank you very much for your quick answer. Anyhow, I still need manual
> action, as I cannot apply your patch (patch fails to complete). It
> appears, that your diff ist also fixing a lot of Python-code, which I
> did not notice when analysing my errors. Could it be that we are
> talking about different code? Anyhow, when looking at your diff, I
> could not understand a particular section.
>
>>diff -r 47ef443bd9b9 src/gui/help/id/id.po
>>--- a/src/gui/help/id/id.po Fri Jul 23 18:38:46 2010 -0700
>>+++ b/src/gui/help/id/id.po Sat Jul 24 13:33:46 2010 -0500
>>@@ -722,8 +722,8 @@
>>  msgstr "Lakukan langkah-langkah berikut untuk memperbarui semua
> paket pada image Anda."
>>
>>  #: package-manager.xml.in.nolegal:324(para)
>>-msgid "Click <guibutton>Updates</guibutton> to start the process of
> updating <emphasis role=\"strong\">all</emphasis> the packages
> installed >in your image."
>>-msgstr "Klik <guibutton>Perbarui</guibutton> untuk memulai proses
> pembaruan\<emphasis role=\"strong\">semua</emphasis> paket-paket yang
>>terinstal pada image Anda."
>>+#msgid "Click <guibutton>Updates</guibutton> to start the process of
> updating <emphasis role=\"strong\">all</emphasis> the packages
> installed >in your image."
>>+#msgstr "Klik <guibutton>Perbarui</guibutton> untuk memulai proses
> pembaruan\<emphasis role=\"strong\">semua</emphasis> paket-paket yang
>>terinstal pada image Anda."
>
> I am new to this and my understanding on this topic is still very
> limited, but I fail to see the change.
> The bit "[...] pembaruan\<emphasis role=\"strong\">semua</emphasis>
> [...]" was my problem and it needed to be changed to "[...]
> pembaruan<emphasis role=\"strong\">semua</emphasis> [...]". This is
> consistent with the error report "illegal character".
>
> Also, I noticed, that your patch fixes line 722 - the offending part
> in my version is found in line 726. This supports my suspicion that we
> might be talking about different code.
>
> Regarding the rest, I fear I am not reading your diff correctly. Are
> the `\n's in msgstr superfluous or missing - because sometimes, you
> removed them, sometimes you added them?
>
> I am sorry that I failed to describe the issue shorter.
> Thank you for your patience, have a nice evening, cheers, Chris
>
> - --
> Christopher J. Ruwe
> cjr at cruwe.de
> Timezone CEST = UTC + 2h
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.15 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkxdys4ACgkQhsho7PQX0VmKHgCguQa9Yy2f+TWInqyNLEGEJz5f
> aMwAn0P/MbT2ob0HRMiiYPQvNDfDhxg3
> =YP3D
> -----END PGP SIGNATURE-----
>
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer

Just fix your $PATH.  No need to apply patches to build PKG.  For 
building most if not all OSol you want /usr/gnu/bin at the end or not in 
your $PATH.

JT