[illumos-Developer] BSD iconv (was Closed-bin accords of the OpenSolaris conference... )

[Gabor Kovesdan]

Em 2010.08.11. 11:39, Joerg Schilling escreveu:
>> Why to make stub implementations? The main code of FreeBSD's iconv
>> resides in libc, only the pluggable conversion modules are implemented
>> as shared libraries. Those 3 calls are already designed to be added to libc.
>>      
> I did not yet look into this part of the code. I was looking at the Solaris
> implementation and the size of some of the modules on Solaris.
>
> BTW: is there a way to download it as a whole as e.g. a TAR archive?
>    
I'll provide that soon, for now I still have one issue to look at and 
also having some unrelated high-priority items on my TODO.
> You could include a module local include file that hides the inclusion of
> <sys/cdefs.h>. It is always better to have such local portability needs
> implemented only once.
>
>    
As I explained before, that include is a must in each file for us.
>> This is probably possible and useful. I'll try to change this. Besides,
>> I have further changes and fixes, which are not yet in the Perforce depot.
>>      
> Does this mean that you believe you are ready for integration from your view?
>    
It's a complex issue but yes, I think so. We have to test it thoroughly 
with Ports Collection. The last portbuild failed with some issues, which 
I resolved since then. Now I'm waiting for the responsable parties to 
have some free resources for my new patch.
> Maybe we can even hide the differences in local files included with
> #include "x.h". I see<sys/cdefs.h>  (as mentioned already) and I see the need
> to keep /usr/include/iconv.h from Solaris and to put anything FreeBSD has into
> an additional local include file.
>    
Why to do that? Our iconv.h may already be compatible with yours 
(compatible in the way that by replacing the include, everything will 
still compile). It already seems to be compatible with GNU iconv.h, I 
can compile everything with our iconv.h but linking to GNU libiconv.
> "GNU compatibility" at iconv level may more be a problem on OpenSolaris as GNU
> iconv (without manually adding aliases) will not recognize many locale names
> used by Solaris since the late 1980s even though these names are still
> permitted by the standard.
>    
We have lots of non-GNU aliases and all GNU ones are supported (except 
one). Besides, adding further aliases is very easy.

Gabor