[illumos-Developer] review request: Open Source iprb

[Carlo Magno Arellano C.]

Hi,

Line 386:

396 if (mac_register(macp, &ip->mach) == DDI_FAILURE) {

According to mac_register man page, you should check for a value 
different than zero in order to return
DDI_FAILURE in the attach function. There is no such a DDI_FAILURE 
return value from mac_register.


On 01/12/2010 02:01 p.m., Garrett D'Amore wrote:
> http://mexico.purplecow.org/gdamore/webrev/iprb/
>
> The above is my from-scratch rewrite of iprb, which supports legacy
> Intel 100 Mbps parts.  Some of these can be found on systems up to and
> including certain ICH 7 motherboards (laptops usually), and probably
> even some Atom motherboards.
>
> I've not done a full nightly yet, although lint is Pass 1 clean and its
> cstyle clean. :-)  Testing so far has gone quite well, although I've not
> yet started a full NICDRV run.  Nonetheless, I'm reasonably confident
> based on the random set of tests that I've done (including some very
> large transfers) that the driver is robust.
>
> The upshot of this is that there might be some changes, but I expect
> them to be modest, and there might not even be any.
>
> So, with that said, I think its an appropriate time for folks to start
> code reviewing the changes.  The driver itself is about 1800 lines in
> the .c file, and about 400 lines in the .h.
>
> If folks would like the specification to which the driver was written,
> they can google for "Intel 8255x Open Source Software Developer Manual",
> or they can ask me and I'll send them a copy.  (Please don't bother me
> with a request unless you're going to use it as part of a code review
> for this driver, though. :-)
>
> Thanks.
>
> 	- Garrett
>
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>