[illumos-Developer] Review: 235 SMF Service reports zfssnap-roleadd in maintenance state & 335 service manifest does not support multiple manpage references for the same keyword

[Garrett D'Amore]

These changes look reasonable to me.   Although I'd recommend using
asprintf() at svccfg_xml.c:1948 and elide 1949 and 19450.  Admittedly, I
don't understand what 1951-1960 are doing, and what the implications of
an unlimited length there would be.

	- Garrett

On Mon, 2010-12-06 at 00:50 -0500, Albert Lee wrote:
> http://pkgdev.openindiana.org/~trisk/235+335/ is a webrev for both:
> 235 SMF Service reports zfssnap-roleadd in maintenance state
> 335 service manifest does not support multiple manpage references for
> the same keyword
> 
> Both of these bugs are implicated in
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6983942
> although only the latter problem was fixed by Oracle. These are
> leading to early termination of 'svccfg cleanup' when certain
> manifests are installed where the root cause is fragile error
> handling. The handling of manifests with the same title in multiple
> manpage sections uses the same property group format (title
> concatenated with section) as Oracle's 151a, while OpenIndiana 148
> received an earlier version of this change that used an underscore
> separator.
> 
> -Albert
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer