[illumos-Developer] BEADM [WEBREV] 418 replace beadm by tbeadm with gettext support

[Alexander Stetsenko]

11.12.2010 09:08, Garrett D'Amore пишет:
> On 12/10/10 08:56 PM, Gordon Ross wrote:
>> When I run xgettext(1) on your beadm.c I get an empty messages.po file
>> (except for the domain line). Unless I'm missing something, I don't 
>> think
>> you have the I18N stuff fixed yet.
>>
>> And I still really don't like beadm_errmsg_init()
>> and referencing messages by labels. I believe
>> that just makes the code harder to read. It may
>> have been useful in the python code, but I see
>> little if any advantage to that method in C code.
>> However, I'm willing to let that go.
>
>
> I tend to concur... I've been avoiding weighing in on this, but I think
>
> printf(_("translated message"));
>
> is much simpler than:
>
> #define MSGID 1
>
> char *messages[] = { .... , __("translated message"), ... };
>
> void do_print(int msg, ... ) ....
>
> ...
> do_print(MSGID);
> ...
>
> Hopefully that makes sense.
did I understand correctly you highly recomended to rewrite this stuff ?
If so, I`ll start working on it
>
>
> - Garrett
>
>> Gordon
>>
>> On Fri, Dec 10, 2010 at 6:05 PM, Alexander Stetsenko<ams at nexenta.com> 
>> wrote:
>>> Thanks for reviews
>>> I tried to fix most of pointed out issues.
>>> This is fixed version of beadm.
>>>
>>> New beadm webrev link:
>>> http://cr.illumos.org/view/9akwb1b3/
>>>
>>> I also attached diff between prev and curr versions
>>>
>>> _______________________________________________
>>> Developer mailing list
>>> Developer at lists.illumos.org
>>> http://lists.illumos.org/m/listinfo/developer
>>>
>>>
>> _______________________________________________
>> Developer mailing list
>> Developer at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/developer
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer