[illumos-Developer] Requesting code review for bug #515 ...

[Roland Mainz]

On Thu, Dec 16, 2010 at 12:46 AM, Eric Schrock <eric.schrock at delphix.com> wrote:
> - Eric
> On Wed, Dec 15, 2010 at 6:16 PM, Roland Mainz <roland.mainz at nrubsig.org>
> wrote:
>>
>> Hi!
>>
>> ----
>>
>> I'd like to request code review for bug #515
>> (http://www.illumos.org/issues/515 - "RFE: Update library dependicies
>> in usr/src/lib/Makefile").
>> The webrev can be found at
>> http://cr.opensolaris.org/~gisburn/illumos_b515_lib_dependicies/
>>
>> Notes:
>> - The purpose of the patch is only to _add_ missing dependicies to
>> prevent "random" build failures when doing a parallel build. We don't
>> try to optimise or change anything else to keep the patch "low-risk"
>> and allow a fast integration (maybe my tomorrow)
>> - References to the closed-source libc_i18n have been removed
>
> Can you explain your criteria for enumerating these dependencies?  Was this
> generated programmatically or by hand?

Created programatically and then merged-in by hand.

> More importantly, can you explain the nature of these changes w.r.t. the
> existing .WAIT directives?  If these changes are indeed complete, shouldn't
> you rip out the .WAIT directives?  Otherwise, most of what you've done
> doesn't serve any purposes (most of the world is serialized by the .WAIT
> after libnvpair, so you don't need to add it everywhere).
> There are other oddities, such as adding libbsm as a dependency of libnwam -
> libnwam appears before libbsm in SUBDIRS separated by the .WAIT directive
> after libnvpair.

The issues with .WAIT are known. The goal for _this_ patch is only to
provide a _low_-risk fix for the current sporadic parallel build
bustage by adding _all_ dependicies (except the one for "libc") only.
There should be no dependicy removals or a larger restructuration (or
sorting the list... Garrett said I should defer that to later, too) -
the goal for this bug is to fix the bustage only (because it blocks
(or delays) contributions).

_After_ fixing this bug I'll setup a parallel machine and try to get
rid of the .WAIT stuff. But this is seperate "feature work" and a
seperate bug.

> How exactly does this situation get interpreted by make?

"make" will honor the .WAIT and the dependices.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)