[illumos-Developer] webrev: removal of "patch" (aka sparse package) support from SVR4 tools

Peter Tribble peter.tribble at gmail.com
Sun Nov 14 08:46:26 PST 2010


On Sun, Nov 14, 2010 at 7:05 AM, Garrett D'Amore <garrett at damore.org> wrote:
> I've removed support for "sparse" packages (i.e. those special patch
> packages that only Sun was ever able to deliver.)  illumos will not be
> supporting this style of "dim-sum" patching; if a patch is necessary
> then the whole package that delivers the patch will be installed.  (Dim
> sum patching, and the problems related to it, were the most often cited
> reason for ditching SVR4 and inventing the IPS packaging system.)
>
> Now, I've also made some other cleanups, mostly to make libadm and
> libpkg lint clean.  (In the process a few genuine bugs were found and
> fixed. :-)
>
> Please review the changes here:
>
> http://mexico.purplecow.org/gdamore/webrev/nopatch/

Nothing major:

usr/src/lib/libpkg/common/pkgxpand.c - can't this just be deleted?

usr/src/lib/libpkg/common/pkgtrans.c - I think that you'll find that once you
whack the device stuff, partcnt and totsize will disappear completely

(likewise, I'm not sure it's worth fixing pkgmount.c)

usr/src/lib/libpkg/common/pkgerr.c - why not just remove pkgerr_dump?

-- 
-Peter Tribble
http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/



More information about the Developer mailing list