[illumos-Developer] ZFS [WEBREV] 278 get rid zfs of python and pyzfs dependencies

[Alexander Stetsenko]

11/30/2010 11:02 PM, Garrett D'Amore пишет:
> On Tue, 2010-11-30 at 22:51 +0300, Alexander Stetsenko wrote:
>> latest zfs command webrev:
>>
>> http://cr.illumos.org/view/xsxn1sfx/
>>
> This looks good.  I think you have had lots of reviews already, and I
> think we can proceed with integration.  So the next steps are:
>
> a) send me the hg outgoing -v output
changeset:   13246:97054227b377
tag:         tip
user:        Alexander Stetsenko <ams at nexenta.com>
date:        Tue Nov 30 22:04:16 2010 +0300

description:
         278 get rid zfs of python and pyzfs dependencies

modified:
    usr/src/cmd/zfs/Makefile
    usr/src/cmd/zfs/zfs_main.c
    usr/src/common/zfs/zfs_deleg.c
    usr/src/common/zfs/zfs_deleg.h
    usr/src/lib/libzfs/common/libzfs.h
    usr/src/lib/libzfs/common/libzfs_dataset.c
    usr/src/lib/libzfs/common/llib-lzfs
    usr/src/lib/libzfs/common/mapfile-vers


> b) send me the hg pbchk output
Copyright check:

C style check:

Header format check:

Java style check:

Mapfile comment check:

File permission check:

Keywords check:

Comments check:

Checking for new tags:

Checking for multiple heads (or branches):

Checking for branch changes:

Checking for uncommitted changes:

Checking for merges:


> c) provide me with details about how you tested it.
First, I tested new zfs in proto area running it with LD_LIBRARY_PATH to 
use libzfs from proto area and compared
output (behavior) with origian zfs.
Second I`ve created BE and tested new zfs with misc combiantion of 
paramenters with my local zfs datasets.
> d) send me the mail_msg file generated by a nightly run.
I`ve attached it.
I had to run nightly twice - first time I forget restore manifest for 
package and get warning:
==== Validating manifests against proto area ====

Entries present in proto area but not manifests:
         dir group=group mode=0755 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs
         file usr/lib/python2.6/vendor-packages/zfs/__init__.py 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/__init__.py
         file usr/lib/python2.6/vendor-packages/zfs/__init__.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/__init__.pyc
         file usr/lib/python2.6/vendor-packages/zfs/allow.py group=group 
mode=0644 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/allow.py
         file usr/lib/python2.6/vendor-packages/zfs/allow.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/allow.pyc
         file usr/lib/python2.6/vendor-packages/zfs/dataset.py 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/dataset.py
         file usr/lib/python2.6/vendor-packages/zfs/dataset.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/dataset.pyc
         file usr/lib/python2.6/vendor-packages/zfs/groupspace.py 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/groupspace.py
         file usr/lib/python2.6/vendor-packages/zfs/groupspace.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/groupspace.pyc
         file usr/lib/python2.6/vendor-packages/zfs/holds.py group=group 
mode=0644 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/holds.py
         file usr/lib/python2.6/vendor-packages/zfs/holds.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/holds.pyc
         file usr/lib/python2.6/vendor-packages/zfs/ioctl.so group=group 
mode=0755 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/ioctl.so
         file usr/lib/python2.6/vendor-packages/zfs/table.py group=group 
mode=0644 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/table.py
         file usr/lib/python2.6/vendor-packages/zfs/table.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/table.pyc
         file usr/lib/python2.6/vendor-packages/zfs/unallow.py 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/unallow.py
         file usr/lib/python2.6/vendor-packages/zfs/unallow.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/unallow.pyc
         file usr/lib/python2.6/vendor-packages/zfs/userspace.py 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/userspace.py
         file usr/lib/python2.6/vendor-packages/zfs/userspace.pyc 
group=group mode=0644 owner=owner 
path=usr/lib/python2.6/vendor-packages/zfs/userspace.pyc
         file usr/lib/python2.6/vendor-packages/zfs/util.py group=group 
mode=0644 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/util.py
         file usr/lib/python2.6/vendor-packages/zfs/util.pyc group=group 
mode=0644 owner=owner path=usr/lib/python2.6/vendor-packages/zfs/util.pyc
         file usr/lib/zfs/pyzfs.py group=group mode=0555 owner=owner 
path=usr/lib/zfs/pyzfs.py
         file usr/lib/zfs/pyzfs.pyc group=group mode=0555 owner=owner 
path=usr/lib/zfs/pyzfs.pyc

Second time I fixed only the manifest and ran nightly incrementally - 
email msg attached

> I think you also need to updated the comment to list your code
> reviewers, using hg reci.  Each reviewer should be on a line like this:
>
> Reviewed by: name at domain.com
Hmm, but I still did not get any response that resume all is ok :(

> Thanks.
>
> 	 - Garrett

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mail_msg
URL: <http://lists.illumos.org/pipermail/developer/attachments/20101130/87e1e582/attachment.ksh>