[illumos-Developer] webrev: printf

[Joerg Schilling]

Guido Berhoerster <guido+illumos.org at berhoerster.name> wrote:

> Not only that but the code Garrett just committed contains a null
> pointer dereference in case no arguments are passed to printf.

Something that shoule be detected by lint. Does this happen?

> If you just go ahead and commit stuff while there is still a
> discussion going on where people (which do not belong to some
> anonymous ksh93 fanboy group) voice legitimate concerns then I
> wonder what the point of doing code reviews is?
> A real code review would probably have caught trivial errors like
> the above.

My impression is that there have been codereviwes for Illumos that were 
not done by people who fully understand the related code. I would not only like 
to see code reviews but wualified reviews.

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily