[illumos-Developer] Webrev to fix Bug 121 please approve

[Garrett D'Amore]

On Sat, 2010-09-04 at 21:57 +0200, Joerg Schilling wrote:
> "Garrett D'Amore" <garrett at nexenta.com> wrote:
> 
> > This looks good.  Next steps to integration:
> >
> > Please verify that you did:
> >
> > a) a full nightly build with it.
> 
> This would not be sufficient

Huh?  Have run a full nightly against your changes, or not?

> 
> > b) testing of that nightly build (ideally with different keyboard
> > layouts configured, with several reboot cycles)
> 
> It has been tested with SchilliX

It should be tested with illumos.  If you have a version of SchilliX
that uses illumos, its possible that this is adequate, but I would like
to know more about how SchilliX differs from OpenSolaris before I make
that assessment.

To date, we have done all our testing with OpenSolaris/illumos.
Deviations from that plan need to be understood.

> 
> > c) hg outgoing -v output that looks correct (post a pastebin somewhere)
> >
> > Once all those things are done, let me know and I'll approve your
> > integration.
> 
> So I asume you approve the putback.

It would be unwise to assume anything.  I need clarification on the
above answers before I approve anything.

	-- Garrett

> 
> hg outgoing -v 
> running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> searching for changes
> 
> changeset:   13168:386f797b783a
> tag:         tip
> user:        J. Schilling <joerg at schily.net>
> date:        Sat Sep 04 21:56:36 2010 +0200
> 
> description:
>         121 Any keypboard but US-Enlish does not work
>         Reviewed by: garrett at nexenta.com
>         Approved by: garrett at nexenta.com
> 
> modified:
>    usr/src/cmd/kbd/keymap
> Jörg
>