[illumos-Developer] tr webrev

[Garrett D'Amore]

On Mon, 2010-09-06 at 16:39 +0000, Paul Armstrong wrote:
> At 2010-09-06T13:29+0200, Joerg Schilling wrote:
> > "Garrett D'Amore" <garrett at nexenta.com> wrote:
> > Unless we have an automated test for tr that would allow to test
> > everything (which is not possible), we could create a "testing" source
> > gate and encourage people to do testing for a longer period of time
> > until we could move the tested bits into the stable gate.
> 
> So this seems like a good time to bring up the question of where we put
> tests.
> 
> We can either have a separate gate or we can create "test" directories
> within the directory of the module to be tested (e.g.
> illumos/usr/src/cmd/zpool/test).
> 
> I generally prefer doing it the subdirectory way (at least for unit and
> regression testing) as that means the tests are something you might
> reasonably expect to require to be checked in at the same time as the
> code (so they don't get forgotten). It also allows the easy addition of
> regression testing make directives so you can do testing during a build.
> Large scale end to end tests that take days to run and are not module
> specific should (IMHO) either be in their own subdirectory or their own
> gate.
> 
> I have similar opinions about man pages and package definitions (that
> is, I tend to prefer to checkin everything to do with a given piece of
> code at the same time with the same commit number so it's easily
> tracked).
> 
> Thoughts?

I tend to agree.  We need to come up with a concrete proposal about this
though.  For some of this (e.g. man pages) there are additional
complexities (how should they be packaged?  What about man page
translations?   Etc.)

	- Garrett

> 
> Paul
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer