[illumos-Developer] tr webrev

[Garrett D'Amore]

On Tue, 2010-09-07 at 14:26 +0100, Ceri Davies wrote:
> On Tue, Sep 07, 2010 at 08:04:27AM -0500, John Grafton wrote:
> > Looks like Rich Lowe just posted a better solution.  There's a issue with ==
> > clobbering the precedence of ^.  His post is on h
> > ttp://illumos.org/issues/132 <http://illumos.org/issues/132>
> 
> OK, looks like this doesn't affect FreeBSD tr on FreeBSD anyway; was
> wondering if there was an upstream bug that had been missed somehow.
> 
> Assuming then that this is compiler related, could someone also post the
> fix to http://www.freebsd.org/send-pr.html ?

Its not compiler related.  I introduced the bug when I tried to correct
the busted style in the upstream code, and misunderstood the original
code and put the parens in the wrong place.  (In fact, the likelihood of
this misunderstanding is why cstyle bitched about in the first place.)

Getting fbsd to understand that relying on operator precedence rules
like the original code does is a bad idea, might be challenging. I don't
know how things like this are viewed in that community.

	- Garrett