[illumos-Developer] [REVIEW] sync with onnv-gate 13149:b23a4dab3d50

[Garrett D'Amore]

I gave it a once over... admittedly some of the review was rather
cursory.  I'd like gwr to review the smb portions.  Otherwise, it seems
OK.

	- Garrett


On Tue, 2010-09-07 at 23:46 -0400, Richard Lowe wrote:
> I'd like code review for the merge with onnv as of its last changeset
> before becoming a closed source project, 13 changesets after onnv_147.
> 
> This includes Emulex's fix for the bug filed in redmine as:
>      #131 Lun Size 0MB with Emulex LP9002L FC Target and snv_134
> 
> A webrev is available from: http://richlowe.net/webrevs/il-omega-merge/
> 
> None of the changes contained therein are my own but sadly webrev makes
> it rather irritating to display the authorship information of
> multi-changeset, multi-author integrations.
> 
> These changes contain no files in common with changesets from
> illumos-gate so there are no file content changes as compared to onnv in
> this webrev and no conflicts were resolved.  Nevertheless it seems
> unwise to assume the code is perfect just because it came out of Oracle
> and I'd like it to be reviewed by eyes other than my own.
> 
> The nature of the SCM means I can't edit the changesets as presented
> here, only make any changes required as followup changesets (regarding
> which I would file bugs).
> 
> I've built these bits debug and release, and booted them in a VM.  In
> minor testing, the only bugs I've hit appear to be pre-existing.  For
> most of these changes a certain amount of faith in the testing performed
> by the people who integrated to onnv-gate is going to be necessary.
> 
> -- Rich
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer