[illumos-Developer] [REVIEW] 174 libpthread uberdata stale after 6735446

Joerg Schilling Joerg.Schilling at fokus.fraunhofer.de
Sat Sep 11 15:07:54 PDT 2010


Gordon Ross <Gordon.Ross at nexenta.com> wrote:

> This is small enough so I'm not bothering with a webrev
> unless someone asks for one.  Please review.  Thx!
>
> --- old/usr/src/lib/libc/inc/thr_uberdata.h
> +++ new/usr/src/lib/libc/inc/thr_uberdata.h
> @@ -860,6 +860,8 @@
>  
>  /*
>   * This is data that is global to all link maps (uberdata, aka super-global).
> + * Note: When changing this, please be sure to keep the 32-bit variant of
> + * this in sync.  (see uberdata32_t below)
>   */
>  typedef struct uberdata {
>  	pad_lock_t	_link_lock;
> @@ -1116,6 +1118,7 @@
>  	caddr32_t	atforklist;
>  	caddr32_t	robustlocks;
>  	caddr32_t	robustlist;
> +	caddr32_t	progname;
>  	caddr32_t	tdb_bootstrap;
>  	tdb32_t		tdb;
>  } uberdata32_t;

Is this a hidden or opaque data structture?
Will anything related to the struct size leak out of libc?

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily



More information about the Developer mailing list