[illumos-Developer] webrev: multibyte locale collation and license cleanups
garrett at damore.org
Sat Sep 18 07:50:10 PDT 2010
On Sat, 2010-09-18 at 09:59 -0400, Kyle McDonald wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On 9/17/2010 11:01 PM, Garrett D'Amore wrote:
> > This is a big review, but its *really* only 2700 lines when you factor
> > out the two files that are each over 20,000 lines. (The UnicodeData.txt
> > file and the generated map file from it.)
> > The review is here:
> > http://mexico.purplecow.org/gdamore/webrev/collate/
> > There are three bugs:
> > c) The locale data for ctype and collate are binary data files. It is
> > wasteful to use network byte ordering for them, since they are not
> > shared across platforms. They are now native byte ordering. This
> > should shave quite a few cycles for x86 boxes when loading these data
> > files. Also, in the future, we can now consider using mmap() of these
> > files (that is the subject of a future RFE) to get even more
> > performance.
> Are these files installed in /usr/share (or /usr/lib/share?) on the
> user's system?
No, they live in /usr/lib/locale. Hence my belief that they do not need
to be endian-neutral. :-)
> If yes, then they should be moved if they are no longer shareable
> across platforms. It's not super common, but I do know of places that
> still mount /usr/share on client machines from a single server. It
> sounds like this breaks that.
No it doesn't. Because the files don't live in a shared directory.
> > Its a big review, and I'm grateful for any feedback I can receive.
> > Thanks!
> > - Garrett
> > _______________________________________________
> > Developer mailing list
> > Developer at lists.illumos.org
> > http://lists.illumos.org/m/listinfo/developer
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (MingW32)
> -----END PGP SIGNATURE-----
More information about the Developer