[illumos-Developer] [REVIEW] 244: Need replacement for closed /usr/bin/tail and /usr/xpg4/bin/tail

[cjlove at san.rr.com]

---- Ian Collins <ian at ianshome.com> wrote: 
> On 09/22/10 05:07 PM, cjlove at san.rr.com wrote:
> > I'd like a review of 244: Need replacement for closed /usr/bin/tail
> > and /usr/xpg4/bin/tail
> >
> > Two webrevs are provided:
> > http://cr.opensolaris.org/~cjlove/tail  - relative to Illumos source tree
> > http://cr.opensolaris.org/~cjlove/tail_freebsd - relative to original FreeBSD code
> >
> > Two testsuites are included in usr/src/cmd/tail/tests: one derived
> > from the libshell testsuite for tail, one derived from the GNU
> > CoreUtils testsuite.  Both testsuites have been validated against
> > legacy Solaris tail and the new tail.
> >
> > I've done nightly and Illumos boots with the replacement tail in
> > place.  There is also an x86 tail binary attached to the defect).
> >
> >    
> Is it customary to add a CDDL notice on modified code?
> 
> What's the logic for the change "if (mip->maplen == 0)" at line 104 in 
> misc.c?

This resolved a lint warning:
"misc.c", line 104: warning: suspicious comparison of unsigned with 0: op 
"<=" (E_SUSPICIOUS_COMPARISON) 

> 
> The change foe case 'l' in tail.c looks scary, but I guess it's safe..
> 
> -- 
> Ian.
>