[illumos-Developer] [REVIEW] 259 SCM tools should work with wider range of Mercurial versions

Garrett D'Amore garrett at damore.org
Sat Sep 25 16:40:51 PDT 2010


It looks pretty good to me.  I note that this will require folks to be
running hg 1.3.1 or later.  What happens if someone tries to run their
existing copy of hg 1.1.2 with this version of cdm?

	- Garrett

On Sat, 2010-09-25 at 18:56 -0400, Richard Lowe wrote:
> I'd like review for
>    259 SCM tools should work with wider range of Mercurial versions
> 
> webrev: http://richlowe.net/webrevs/il-cdm-16
> 
> This has been reviewed in various incarnations previously, on
> tools-discuss and elsewhere, but has obviously changed since, as new
> versions of Mercurial have appeared.
> 
> The people you'd have expected who tend to review such things signed off
> on the last (early 1.5.x?) copy I sent out, prior to onnv vanishing, but
> the changes got blocked on testing of the onnv-gate specific hooks with
> this code.  That's something we don't have to worry about.
> 
> I'd like reviewers to keep that in mind, but please do be as thorough as
> you feel the need to be.
> 
> If you're going to review, but not immediately, please say so, so that I
> know to wait for you.
> 
> Testing has been my use of this, with the various versions, in its
> various forms, for far too long, plus the 'cadtest' test suite commonly
> used for testing changes to the Cadmium mercurial extension.
> 
> Thanks,
> 
> -- Rich





More information about the Developer mailing list