[illumos-Developer] Review --> iSCSI UNMAP support

Dan McDonald danmcd at nexenta.com
Thu Feb 10 07:13:23 PST 2011


On Thu, Feb 10, 2011 at 08:17:28AM -0500, Eric Schrock wrote:

<SNIP!>

> Yes, both of these need to be fixed - see my response to Sumit.

Yeah, I saw that.  No direct DMU calls.  I think I got it.

> The changes are trivial, and make the behavior correct (in the
> refreservation case)

So yank these special checks, and...

> and the architecture extensible (in the ioctl case).  I don't see any
> pressure that would necessitate sacrificing quality or correctness with
> this change.

... if these changes truly are trivial, then even a storage newbie like
myself should be able to crank 'em out today.  Watch this space for an update
later today.

Thanks for your patience,
Dan



More information about the Developer mailing list