[illumos-Developer] Now with zfs-ops-in-an-ioctl: iSCSI UNMAP (1st draft)

[Matthew Ahrens]

I don't understand the volume subsystems very well so take this with a
grain of salt.

Why is this an ioctl on /dev/zfs, rather than an operation on the zvol
itself?  I'd expect this to either come in from a call in sbd_zvol.c,
or from a callback in struct cb_ops zfs_cb_ops.

If you have to do it from a zfsdev ioctl, you will at least need to
make sure the objset is a zvol.  And I'd prefer to put the actual
free_long_range in zvol code (ie, have zfs_ioctl.c marshall the
arguments and call zvol_trim() in zvol.c)

--matt

On Mon, Feb 14, 2011 at 3:16 PM, Dan McDonald <danmcd at nexenta.com> wrote:
> Hello again!  (Especially ZFSers like Eric.)
>
> I have compiled and modlintlib-checked these changes, but I have not run them
> yet.  Why?  Because I wanted to first make sure that I was not on too many
> drugs while placing the zvol-specific operations into a nice ZFS_IOC_UNMAP
> ioctl.
>
> Here's the webrev:
>
>        http://www.kebe.com/~danmcd/webrevs/unmap/
>
> I'd especially appreciate folks looking at any KEBE comments and answering
> the questions there.
>
> Thanks,
> Dan
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>