[illumos-Developer] Code review for /usr/bin/iconv replacement...

[Deano]

Code looks good to me.

Bye,
Deano

-----Original Message-----
From: Roland Mainz [mailto:roland.mainz at nrubsig.org] 
Sent: 11 January 2011 03:45
To: illumos-dev
Subject: [illumos-Developer] Code review for /usr/bin/iconv replacement...

Hi!

----

Requesting code review for http://www.illumos.org/issues/30 ("Need
iconv"). The code imports the AT&T AST code for "iconv" to get a
minimum working version of "iconv".

The webrev is available at:
http://cr.opensolaris.org/~gisburn/illumos_b30_need_iconv/

Notes:
- The goal for this putback is to get a _minimum_ functional version
of "iconv" which should remove the dependicy to the closed-source
/usr/bin/iconv utilty from Sun/Oracle.
- The goal for this putback is _not_ to get 100% feature parity with
Sun's version. Right now we only need to get to a point where
real-world consumers like those in SFWNV and l10n message catalog
generation work. More functionality will be gradually added over time
or if there is a demand for a specific feature
- Option "-l" to "Write all supported fromcode and tocode values to
standard output in an unspecified format." is currently not supported
since there is no portable API to do it. We'll deliver a matching API
and the "-l" option in a seperate putback.
- usr/src/cmd/iconv/common/iconv.c is externally maintained so
"cstyle"&co. rules do not apply

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)

_______________________________________________
Developer mailing list
Developer at lists.illumos.org
http://lists.illumos.org/m/listinfo/developer