[illumos-Developer] webrev: audiocmihd driver

Garrett D'Amore garrett at damore.org
Mon Jan 17 08:04:00 PST 2011


On Mon, 2011-01-17 at 15:25 +0100, Mathieu Simon wrote:
>  Hi
> 
> I am not a person with C affininity but out of interest I gave a
> glimpse at the webrev, I can't comment
> much on, but at least give a try:
> 
> My first impression was that audiocmihd was an expanded version of
> audiocmi (I asked myself why not have just one?). 
> Although they share some (small) parts, they differ too much, so there
> seems to be obvious reasons to have two drivers.

Yes, the hardware has little to do with each other.

> 
> One little detail: I was just a bit confused by the copyright
> attribution in usr/src/pkg/manifests/driver-audio-audiocmihd.mf
> since according to the patch it's a new file - but then copyright is
> Oracle and not to 4Front or Dev Mazumdar, why?

Because the file was created by copying a similar file that had an
Oracle copyright.   I probably should have *also* affixed a Nexenta
Copyright, and I'll do that now... (because I made the changes for this
manifest, not 4Front.)

	- Garrett

> 
> - Mathieu
> 
> 
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list