[illumos-Developer] Cluster hook functions in "inet/tcp.h"

Garrett D'Amore garrett at nexenta.com
Mon Jan 17 08:46:46 PST 2011


On Mon, 2011-01-17 at 10:45 +0100, Sergio Lopez wrote:
> Hi,
> 
> Currently, "inet/tcp.h" declares the following hook functions for
> cluster networking:
> 
> extern void     (*cl_inet_listen)(netstackid_t, uint8_t, sa_family_t,
>                     uint8_t *, in_port_t, void *);
> extern void     (*cl_inet_unlisten)(netstackid_t, uint8_t, sa_family_t,
>                     uint8_t *, in_port_t, void *);
> 
> Recent versions of OHAC/colorado define these functions by its own,
> causing the compiler to complain when building. Since AFAIK these hooks
> are only used by OHAC, perhaps it should be considered to remove them
> from the public headers (internally, they're already defined in
> "inet/tcp_cluster.h").
> 
> What do you think?


I need to look at these.  If the definitions are not conflicting, but
represent callbacks done by tcp, then the definitions belong in ON, not
the OHAC sources.

Probably its OHAC that needs to update, but I'll know more when I have a
few minutes to look deeper.

	-Garrett




More information about the Developer mailing list