[illumos-Developer] Review for 613 sed usage missing newline

[Damian Wojslaw]

  On 01/26/11 20:38, Damian Wojsław wrote:
> W dniu 2011-01-26 20:04, Garrett D'Amore pisze:
>> You didn't need to add special handling of -h; as that could collide
>> with future POSIX functionality, please remove it.  (My initial bug
>> report was crummy in this regard, sorry about that.)
>
> My fault, really, as I should research it more. Lesson for me for future.
>
>> The other thing is that I think you need to use cadmium --
>> run /opt/onbld/bin/hgsetup -- using hgsetup from illumos of course.  Our
>> cadmium includes working checks against the illumos bug database, the
>> old one checks Oracle which is why you have that message from hg pbchk.
>>
>>     - Garrett
> Ok, will do that, along with whle nightly.
>
> Regards
The issue is updated with whole nightly built. New sed output:

/usr/bin/sed -h
usage: sed script [-Ealn] [-i extension] [file...]


Webrev at: http://cr.illumos.org/view/ehytg8mf/

Patch for the issue attached.



http://www.illumos.org/issues/613#change-1525
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: illumos-gate.patch
URL: <http://lists.illumos.org/pipermail/developer/attachments/20110127/17fc929b/attachment.ksh>