[illumos-Developer] Review for 573 stmfadm doesn't display target and initiator aliases for iscsit

[Garrett D'Amore]

strdup/strfree would handle CJK as every encoding we support prohibits
NULL bytes within even multibyte characters.  (In fact, I believe that
all of our encodings have the attribute that if a byte is not a
standalone ASCII byte, then it will have the high order bit set, making
it impossible to confuse ASCII with bytes that are part of a multibyte
character.)

	- Garrett

On Sun, 2011-01-30 at 19:54 +0000, Deano wrote:
> Hi Yuri,
> Code looks good to me, has it been tested with more exotic alias names? (CJK
> characters for example). Though assuming strdup/free and nvpair handles them
> then so should this code.
> 
> Bye,
> Deano
> 
> -----Original Message-----
> From: Yuri Pankov [mailto:yuri.pankov at gmail.com] 
> Sent: 30 January 2011 19:22
> To: developer at lists.illumos.org
> Subject: [illumos-Developer] Review for 573 stmfadm doesn't display target
> and initiator aliases for iscsit
> 
> Hi,
> 
> I'm asking for review for 573 stmfadm doesn't display target and
> initiator aliases for iscsit:
> 
> http://www.illumos.org/issues/573
> 
> Webrev:
> http://darklight.org.ru/webrev/573-iscsit-aliases/
> 
> 
> TIA,
> Yuri
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer