[illumos-Developer] Review for 573 stmfadm doesn't display target and initiator aliases for iscsit

[Garrett D'Amore]

Looks good to me!  If nobody has any other review feedback within 48
hours, then I think you should file an RTI.  The way you do that is
contact an advocate (I'm one!), and include this info, your webrev, the
output from hg outgoing -v, hg pbchk, and a mail_msg from a full nightly
build.  I'm happy to work with you on those out of band if you need
help.

	- Garrett

On Mon, 2011-01-31 at 01:19 +0300, Yuri Pankov wrote:
> On Sun, Jan 30, 2011 at 12:44:05PM -0800, Garrett D'Amore wrote:
> > Testing sounds good... I'd like you to test with kmem_flags=0xf on the
> > target (stick in /etc/system and reboot), to make sure we don't have
> > KMEM overruns or other heap corruption.
> > 
> > 	- Garrett
> 
> I hope that I got that right, adding 'set kmem_flags=0xf' to /etc/system
> (thanks for the hint, BTW). Everything seems to work fine so far. Some
> testing steps below (aliases include some cyrillic and simplified
> chinese characters):
> 
> # itadm create-target -l 'test 123 тест 123 灵活性'
> Target iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084 successfully created
> # stmfadm list-target -v
> Target: iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084
>     Operational Status: Online
>     Provider Name     : iscsit
>     Alias             : test 123 тест 123 灵活性
>     Protocol          : iSCSI
>     Sessions          : 0
> # stmfadm list-target -v
> Target: iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084
>     Operational Status: Online
>     Provider Name     : iscsit
>     Alias             : test 123 тест 123 灵活性
>     Protocol          : iSCSI
>     Sessions          : 1
>         Initiator: iqn.1993-08.org.debian:01:2270c61d7a2
>             Alias: 灵活性 123 тест 123 test 123
>             Logged in since: Mon Jan 31 01:11:55 2011
> # itadm modify-target iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084 -l none
> Target iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084 successfully modified
> # stmfadm list-target -v
> Target: iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084
>     Operational Status: Online
>     Provider Name     : iscsit
>     Alias             : -
>     Protocol          : iSCSI
>     Sessions          : 1
>         Initiator: iqn.1993-08.org.debian:01:2270c61d7a2
>             Alias: 灵活性 123 тест 123 test 123
>             Logged in since: Mon Jan 31 01:11:55 2011
> # stmfadm offline-target iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084
> # itadm delete-target iqn.1986-03.com.sun:02:4f97602a-ff06-eb72-ecd6-a0bfc9492084
> #
> 
> 
> Yuri
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer