[illumos-Developer] [illumos-Discuss] webrev: audiocmihd driver

[Garrett D'Amore]

(This is the driver for ASUS Xonar cards.)

I've updated the webrev (same URL -- see below) to address several
issues:

a) mutexes not initialized
b) initial volume level improperly set to 0 on one of the channels
c) leak (or ASSERT on debug kernels) on detach
d) fixes from 4Front for stereo and record gain controls
e) missing reference in the intel Makefile.intel.shared
f) copyright updates
g) fix incorrect handling of missing controls

I've actually tested the code myself this time, and it seems to give
satisfactory results.  Assuming nobody notices anything else wrong with
this driver, I'll be pushing this into the tree in the next couple of
days.  I would appreciate timely review feedback, and if folks want to
help test -- let me know and I'll supply test binaries.

	- Garrett

On Sat, 2011-01-15 at 21:33 -0800, Garrett D'Amore wrote:
> The webrev is here:
> 
> http://mexico.purplecow.org/gdamore/webrev/audiocmihd/
> 
> The code in this webrev was donated by 4Front technologies, and is a new 
> driver for the CMI 8788 chips such as found in ASUS Xonar higher end 
> audio cards.
> 
> This is the first of two recent donations by 4Front to illumos -- the 
> second is a driver for the Envy24HT audio parts found on modern Via 
> chipsets.   (I'll be posting the envy24ht driver a bit later.)
> 
> I have done some minor lint, cstyle, and small fixes to the driver since 
> its receipt (specifically I fixed a problem with Center/LFE handling), 
> but otherwise its verbatim from 4Front.
> 
> This webrev is significant because it represents the first significant 
> vendor contribution to illumos (aside from Nexenta of course).
> 
> My thanks to Dev Mazumdar and 4Front for this contribution.
> 
> The timer for this review expires in one week.
> 
>    -- Garrett
> 
> 
> _______________________________________________
> Discuss mailing list
> Discuss at lists.illumos.org
> http://lists.illumos.org/m/listinfo/discuss