[illumos-Developer] Code review: Feature #677 - Allow adjustment of cache timeout in idmapd

[Garrett D'Amore]

Looks good to me.

     - Garrett

On 01/31/11 06:49 PM, Gordon Ross wrote:
> Updated to include macros for the default timeouts.
>
> http://cr.illumos.org/view/k47c4wv9/
>
> Yes, these were apparently "pulled out of the air".  They're long enough in most
> situations, but cause problems when an object has a lot of mapped IDs, as
> described in the issue.
>
> I think most customers will not need to adjust these, but for those who do,
> this will be a very useful "knob" to have.
>
> Gordon
>
> On Sat, Jan 29, 2011 at 10:35 PM, Garrett D'Amore<garrett at nexenta.com>  wrote:
>    
>> Looks pretty good to me.  I wonder where the 10 minutes and 1 hour came
>> from though.  They feel like they should be placed as macros in a common
>> header with other compile-time defaults (if any).
>>
>>         - Garrett
>>
>> On Sat, 2011-01-29 at 16:26 -0500, Gordon Ross wrote:
>>      
>>> Please review the implementation of:
>>>
>>> Feature #677: Allow adjustment of cache timeout in idmapd
>>> https://www.illumos.org/issues/677
>>>
>>> Here's the webrev:
>>> http://cr.illumos.org/view/xjhhzxeh/
>>>
>>> Thanks,
>>> Gordon
>>>
>>> _______________________________________________
>>> Developer mailing list
>>> Developer at lists.illumos.org
>>> http://lists.illumos.org/m/listinfo/developer
>>>        
>>
>>
>>