[illumos-Developer] [REVIEW] 1121 smbsrv should use SPNEGO (outbound authentication)

Robert Gordon rbg at openrbg.com
Wed Jul 6 13:52:26 PDT 2011


looks good, one very very minor nit. 

line 119 of smbrdr_glue.c could just return err since the smb_ctx_alloc() will not return an allocated smb_ctx, and we don't need to handle that at the errout: label. 

Robert. 

On Jul 6, 2011, at 3:32 PM, Gordon Ross wrote:

> On Wed, Jun 29, 2011 at 11:37 AM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
>> Anyone else want to review this? Or shall I just RTI it with one reviewer?
> 
> I got some more review feedback.
> Here are deltas from the previous:
>  http://www.yalms.org/cr/illumos-1121a/
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer




More information about the Developer mailing list