[illumos-Developer] [REVIEW] 1037, 1199, 1200 (random symbol in bfe, missing 'static' in efe, misplaced function prototypes)

Gordon Ross gordon.w.ross at gmail.com
Tue Jul 12 12:48:06 PDT 2011


LGTM

On Tue, Jul 12, 2011 at 3:45 PM, Richard Lowe <richlowe at richlowe.net> wrote:
> I'd like review for:
>  1200 various modules declare static functions within function bodies
>  1199 efe_restart should be as static as its prototype
>  1037 bfe references random 'halt' symbol
>
> webrev:
>  http://richlowe.net/webrevs/il_1200
>
> 1037 and 1199 are hopefully obvious, there's a brief discussion of
> 1200 in the bug, though I'd argue for it on taste grounds regardless.
>
> -- Rich



More information about the Developer mailing list