[illumos-Developer] Review 1116,1208, 1154

[Alexander Eremin]

On Jul 14, 2011, at 7:42 PM, Gary Mills wrote:

> On Thu, Jul 14, 2011 at 06:49:34PM +0400, Alexander Eremin wrote:
>>
>>   I'd like review for next fixes:
>>
>>   1116 beadm *_snap commands shouldn't exist
>>
>>   1208 beadm doesn't show BE snapshots
>>
>>   webrev: [1]http://cr.illumos.org/view/7zjkkv35/
>
> The webrev looks fine, but I can't tell from that how beadm behaves
> now.  Could you show us that?

Sure. It lose this functionality from ALTERNATE_BE implementation,  
that's my fault ;)

# beadm list -s lx

BE/Snapshot                        Space Policy Created
lx
    lx at 2011-07-13-15:06:03          0     static 2011-07-13 19:06
    lx at 2011-07-13-16:15:23          0     static 2011-07-13 20:15
    lx at bla                          0     static 2011-07-13 20:16
    lx at test                         0     static 2011-07-13 18:39
    lx at test3                        0     static 2011-07-13 20:07


# beadm list -a lx
BE/Dataset/Snapshot                  Active Mountpoint Space Policy  
Created
lx
    rpool/ROOT/lx                     -      -          176   static  
2011-06-22 13:31
    rpool/ROOT/lx at 2011-07-13-15:06:03 -      -          0     static  
2011-07-13 19:06
    rpool/ROOT/lx at 2011-07-13-16:15:23 -      -          0     static  
2011-07-13 20:15
    rpool/ROOT/lx at bla                 -      -          0     static  
2011-07-13 20:16
    rpool/ROOT/lx at test                -      -          0     static  
2011-07-13 18:39
    rpool/ROOT/lx at test3               -      -          0     static  
2011-07-13 20:07


>
>>   1154 cpio needs a quiet option
>>
>>   webrev: [2]http://cr.illumos.org/view/ju1r6k7n/
>
> That's my bug!  The fix looks good to me.  Thanks.

Yep, I use it often in scripts too, so I understand you )
>
> -- 
> -Gary Mills-        -Unix Group-        -Computer and Network  
> Services-


Thanks,
:: Alexander