[illumos-Developer] Review 1116,1208, 1154

[Yuri Pankov]

On Thu, Jul 14, 2011 at 11:08:36AM -0400, Dan McDonald wrote:
> On Thu, Jul 14, 2011 at 07:05:51PM +0400, Yuri Pankov wrote:
> > > 1154 cpio needs a quiet option
> > > 
> > > webrev: http://cr.illumos.org/view/ju1r6k7n/
> > 
> > Both GNU and BSD cpio support only --quiet long-style option, maybe we
> > could do the same for compatibility?
> 
> I don't think our cpio has any long-style option support.  Pulling that
> thread would unravel too much sweater.

All needed support is already there :-)

This should be as easy as:
--- cpio.c.patched      Thu Jul 14 19:50:12 2011
+++ cpio.c.reallyquiet  Thu Jul 14 19:49:49 2011
@@ -6383,24 +6383,24 @@
 #if defined(O_XATTR)
 #if defined(_PC_SATTR_ENABLED)
 #ifdef WAITAROUND
-       char    *opts_p = "zabcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6@/";
+       char    *opts_p = "zabcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6@/";
 #else
-       char    *opts_p = "abcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6@/";
+       char    *opts_p = "abcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6@/";
 #endif /* WAITAROUND */

 #else  /* _PC_SATTR_ENABLED */
 #ifdef WAITAROUND
-       char    *opts_p = "zabcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6@";
+       char    *opts_p = "zabcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6@";
 #else
-       char    *opts_p = "abcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6@";
+       char    *opts_p = "abcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6@";
 #endif /* WAITAROUND */
 #endif /* _PC_SATTR_ENABLED */

 #else  /* O_XATTR */
 #ifdef WAITAROUND
-       char    *opts_p = "zabcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6";
+       char    *opts_p = "zabcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6";
 #else
-       char    *opts_p = "abcdfiklmopqrstuvABC:DE:H:I:LM:O:PR:SV6";
+       char    *opts_p = "abcdfiklmopq(quiet)rstuvABC:DE:H:I:LM:O:PR:SV6";
 #endif /* WAITAROUND */
 #endif /* O_XATTR */

but as Alexander said, this can be done in separate enhancement.


Yuri